Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Gossip seen_ttl parameter #130

Closed
Nashatyrev opened this issue Jul 31, 2020 · 0 comments · Fixed by #145
Closed

Implement Gossip seen_ttl parameter #130

Nashatyrev opened this issue Jul 31, 2020 · 0 comments · Fixed by #145

Comments

@Nashatyrev
Copy link
Collaborator

Currently the seen message buffer is an LRU Set with hardcoded length 10000
We need more flexible configuration on this structure (ethereum/consensus-specs#1958):

  • seen_ttl: how many heartbeats the message ID shouldn't be pruned from the buffer
  • seen_max: should limit the buffer size (to avoid out of mem) and in case of overflow delete older entries overriding previous parameter behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant