re-added bls_to_execution_changes as a batch #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
previously approved these changes
Dec 8, 2022
rkapka
approved these changes
Dec 8, 2022
michaelsproul
approved these changes
Dec 8, 2022
3 tasks
This was referenced Dec 12, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After further discussion on discord about #275 which was closed, there's more positive sentiment about this now, so re-opening.
The user flow would be generating withdrawals potentially offline with a tool such as ethdo, and taking the generated file to submit on a BN. Ethdo as a specific example does generate this structure already, which would allow users not to have to alter the file once it has been generated.
from original:
The bls_to_execution_change process is probably better modelled as a batch of changes to make.
Changed the api to model this, allowing for messages in responses in case there are errors that need specific reporting.
Given that this API isn't yet released, I made the change in place to the existing api, rather than versioning, and it's unlikely that we need both single and multi-submission, it's easy enough to wrap a single in an array object.