Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-added bls_to_execution_changes as a batch #279

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

rolfyone
Copy link
Collaborator

@rolfyone rolfyone commented Dec 8, 2022

After further discussion on discord about #275 which was closed, there's more positive sentiment about this now, so re-opening.

The user flow would be generating withdrawals potentially offline with a tool such as ethdo, and taking the generated file to submit on a BN. Ethdo as a specific example does generate this structure already, which would allow users not to have to alter the file once it has been generated.

from original:

The bls_to_execution_change process is probably better modelled as a batch of changes to make.

Changed the api to model this, allowing for messages in responses in case there are errors that need specific reporting.

Given that this API isn't yet released, I made the change in place to the existing api, rather than versioning, and it's unlikely that we need both single and multi-submission, it's easy enough to wrap a single in an array object.

rkapka
rkapka previously approved these changes Dec 8, 2022
Copy link
Collaborator

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, consensus seems to be in favour of the batch!

Let's merge this so we can move ahead with the changes for the next devnets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants