Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC-4824: Move to Review #330

Merged
merged 29 commits into from
Jun 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
50e36bb
move to Review status
thelastjosh Mar 14, 2024
40916cf
move contract from ERC file to assets folder
thelastjosh Mar 14, 2024
e2d2e3d
Merge pull request #1 from thelastjosh/patch-1
thelastjosh Mar 14, 2024
a68c0a8
add section for entities which are not DAOs
thelastjosh Mar 15, 2024
d445fcb
Add support for removing or adding URI suffix to fields
thelastjosh Mar 15, 2024
311023d
change all http to https, norm for empty fields
thelastjosh Mar 15, 2024
cf84401
clarified URI precedence
thelastjosh Mar 15, 2024
fb041ca
clarify rationale and instructions for contractsURI
thelastjosh Mar 15, 2024
ca3e1c3
add indexing priority and rationale
thelastjosh Mar 15, 2024
3a4009c
remove double copy of "activities" object in activity log
thelastjosh Mar 15, 2024
a46c17c
typos
thelastjosh Mar 15, 2024
78e4e4b
Clarify contractsURI requirements
thelastjosh Mar 15, 2024
0d8b8d1
removed reference implementation of factory contract, added link to a…
thelastjosh Mar 15, 2024
dd2c740
clarify update method expectation
thelastjosh Mar 19, 2024
181f1a1
typo
thelastjosh Mar 19, 2024
21600ac
removed extraneous instances of "name" of the DAO in sub-URIs
thelastjosh Mar 19, 2024
eca2690
removed "type" clarification for members in favor of caip10/eip155 an…
thelastjosh Mar 19, 2024
a1263c5
typo
thelastjosh Mar 19, 2024
c31537e
remove extraneous "type" field from sub-URI JSONs
thelastjosh Mar 19, 2024
2103dc7
Update erc-4824.md
thelastjosh Mar 19, 2024
f1288db
removed link to reference implementation for now
thelastjosh Mar 19, 2024
4b96094
Merge branch 'master' into master
thelastjosh Mar 19, 2024
dbb67d1
Create ERC4824Registration.sol
thelastjosh Jun 11, 2024
1d9912a
changes in response to EIP editor suggestions
thelastjosh Jun 11, 2024
2f813dd
Apply suggestions from code review
thelastjosh Jun 11, 2024
704aed6
typo fix
thelastjosh Jun 11, 2024
9dfb172
Merge branch 'master' into master
thelastjosh Jun 11, 2024
b019ca7
Editor suggestions
SamWilsn Jun 11, 2024
f826c9d
Merge pull request #3 from SamWilsn/SamWilsn-thelastjosh-patch-1
thelastjosh Jun 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading