Update ERC-4824: Move to Review #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move to Review status
including persons, organizations, foundations, etc.
also changed the ordering of the new added sections, clarified norm for removing fields
…d did format syntax
|
✅ All reviewers have approved. |
17 tasks
|
The commit 2103dc7 (as a parent of fb4e937) contains errors. |
EIP bot throwing an error
13 tasks
thelastjosh
added a commit
to metagov/daostar
that referenced
this pull request
Mar 19, 2024
18 tasks
SamWilsn
reviewed
Apr 2, 2024
|
Responded to all review suggestions, moved the smart contract out into assets. Should be ready to move to review! |
|
Put up a pull request with some minor fixes: thelastjosh#3 |
Editor Suggestions for ERC-4824
Merged! |
SamWilsn
approved these changes
Jun 11, 2024
eip-review-bot
approved these changes
Jun 11, 2024
|
Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the example contract to the assets folder, made various minor clarifications about how daoURI and indexing should work, supplemented the rationale, changed the id format for members to align more closely with CAIP-10 (already used for proposals), and fixed a bunch of typos. All changes are backward compatible.