Update EIP-4910: Move to Final #6843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-status
|
✅ All reviewers have approved. |
eth-bot
changed the title
lightclient
previously requested changes
Apr 14, 2023
The Jekyll bot fails due to a missing HTML file. That is on the github side though, I think. I have a question: If I cannot use inline HTML how can I make a requirement externally referencable through a URL? If I use e.g. |
23 tasks
SamWilsn
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
@lightclient I'm okay with the inline HTML in this proposal, but I don't want to clear your review in case you strongly object.
eth-bot
approved these changes
Apr 18, 2023
20 tasks
eth-bot
approved these changes
May 2, 2023
eth-bot
approved these changes
May 2, 2023
eth-bot
approved these changes
May 2, 2023
eth-bot
approved these changes
May 3, 2023
eth-bot
approved these changes
Jun 7, 2023
eth-bot
approved these changes
Jun 7, 2023
13 tasks
eth-bot
approved these changes
Jun 7, 2023
SamWilsn
previously approved these changes
Jun 8, 2023
eth-bot
approved these changes
Jun 8, 2023
eth-bot
previously approved these changes
Jun 8, 2023
|
@lightclient I think you'll need to dismiss your review? |
15 tasks
auto-merge was automatically disabled
June 27, 2023 17:54
Head branch was pushed to by a user without write access
Therecanbeonlyone1969
dismissed stale reviews from eth-bot and SamWilsn
via
ffd220e
15 tasks
eth-bot
previously approved these changes
Jul 12, 2023
eth-bot
approved these changes
Jul 12, 2023
|
The commit 14f08a1 (as a parent of 1c44d6c) contains errors. |
SamWilsn
added a commit
that referenced
this pull request
Sep 13, 2023
* Initial submission of L2 Token List Draft * updated headers (cut and paste error) * fixing cli errors * fixing cli errors * fix cli errors * fixing cli errors * fixing cli errors * fix cli errors * fix cli errors * fixing cli errors * fix cli errors * fixing cli errors * fixing final cli error * updated file name etc. to PR number * Fixing markdown linter errors @Pandapip1 -- the issue is now the same with inline HTM as with #6843. Please, approve if this is ok. I had asked @lightclient for an alternative to make individual requirements referenceable through a URL, apart from inline or using ##### which is not allowed either. * fixing some more markdown linter errors * fixing markdown linter errors * fixing one markdown error apart from inline * Commit from EIP-Bot * fixing unexplained file naming and EIP number errors * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Updates per request from @SamWilsn * correcting CI issues * fixed error in rfc links * fixing CI issues * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * updating PRs based on @SamWilsn requests * Update EIPS/eip-6734.md --------- Co-authored-by: eth-bot <[email protected]> Co-authored-by: Sam Wilson <[email protected]>
streamnft-tech
pushed a commit
to streamnft-tech/EIPs
that referenced
this pull request
Oct 27, 2023
* Initial submission of L2 Token List Draft * updated headers (cut and paste error) * fixing cli errors * fixing cli errors * fix cli errors * fixing cli errors * fixing cli errors * fix cli errors * fix cli errors * fixing cli errors * fix cli errors * fixing cli errors * fixing final cli error * updated file name etc. to PR number * Fixing markdown linter errors @Pandapip1 -- the issue is now the same with inline HTM as with ethereum#6843. Please, approve if this is ok. I had asked @lightclient for an alternative to make individual requirements referenceable through a URL, apart from inline or using ##### which is not allowed either. * fixing some more markdown linter errors * fixing markdown linter errors * fixing one markdown error apart from inline * Commit from EIP-Bot * fixing unexplained file naming and EIP number errors * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Updates per request from @SamWilsn * correcting CI issues * fixed error in rfc links * fixing CI issues * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * updating PRs based on @SamWilsn requests * Update EIPS/eip-6734.md --------- Co-authored-by: eth-bot <[email protected]> Co-authored-by: Sam Wilson <[email protected]>
RaphaelHardFork
pushed a commit
to RaphaelHardFork/EIPs
that referenced
this pull request
Jan 30, 2024
* Initial submission of L2 Token List Draft * updated headers (cut and paste error) * fixing cli errors * fixing cli errors * fix cli errors * fixing cli errors * fixing cli errors * fix cli errors * fix cli errors * fixing cli errors * fix cli errors * fixing cli errors * fixing final cli error * updated file name etc. to PR number * Fixing markdown linter errors @Pandapip1 -- the issue is now the same with inline HTM as with ethereum#6843. Please, approve if this is ok. I had asked @lightclient for an alternative to make individual requirements referenceable through a URL, apart from inline or using ##### which is not allowed either. * fixing some more markdown linter errors * fixing markdown linter errors * fixing one markdown error apart from inline * Commit from EIP-Bot * fixing unexplained file naming and EIP number errors * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Updates per request from @SamWilsn * correcting CI issues * fixed error in rfc links * fixing CI issues * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * updating PRs based on @SamWilsn requests * Update EIPS/eip-6734.md --------- Co-authored-by: eth-bot <[email protected]> Co-authored-by: Sam Wilson <[email protected]>
just-a-node
pushed a commit
to connext/EIPs
that referenced
this pull request
Feb 17, 2024
* Initial submission of L2 Token List Draft * updated headers (cut and paste error) * fixing cli errors * fixing cli errors * fix cli errors * fixing cli errors * fixing cli errors * fix cli errors * fix cli errors * fixing cli errors * fix cli errors * fixing cli errors * fixing final cli error * updated file name etc. to PR number * Fixing markdown linter errors @Pandapip1 -- the issue is now the same with inline HTM as with ethereum#6843. Please, approve if this is ok. I had asked @lightclient for an alternative to make individual requirements referenceable through a URL, apart from inline or using ##### which is not allowed either. * fixing some more markdown linter errors * fixing markdown linter errors * fixing one markdown error apart from inline * Commit from EIP-Bot * fixing unexplained file naming and EIP number errors * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Updates per request from @SamWilsn * correcting CI issues * fixed error in rfc links * fixing CI issues * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * updating PRs based on @SamWilsn requests * Update EIPS/eip-6734.md --------- Co-authored-by: eth-bot <[email protected]> Co-authored-by: Sam Wilson <[email protected]>
GAEAlimited
pushed a commit
to GAEAlimited/EIPs
that referenced
this pull request
Jun 19, 2024
* Initial submission of L2 Token List Draft * updated headers (cut and paste error) * fixing cli errors * fixing cli errors * fix cli errors * fixing cli errors * fixing cli errors * fix cli errors * fix cli errors * fixing cli errors * fix cli errors * fixing cli errors * fixing final cli error * updated file name etc. to PR number * Fixing markdown linter errors @Pandapip1 -- the issue is now the same with inline HTM as with ethereum#6843. Please, approve if this is ok. I had asked @lightclient for an alternative to make individual requirements referenceable through a URL, apart from inline or using ##### which is not allowed either. * fixing some more markdown linter errors * fixing markdown linter errors * fixing one markdown error apart from inline * Commit from EIP-Bot * fixing unexplained file naming and EIP number errors * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Updates per request from @SamWilsn * correcting CI issues * fixed error in rfc links * fixing CI issues * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * updating PRs based on @SamWilsn requests * Update EIPS/eip-6734.md --------- Co-authored-by: eth-bot <[email protected]> Co-authored-by: Sam Wilson <[email protected]>
blacksnow2
pushed a commit
to blacksnow2/EIPs
that referenced
this pull request
Jul 21, 2024
* Initial submission of L2 Token List Draft * updated headers (cut and paste error) * fixing cli errors * fixing cli errors * fix cli errors * fixing cli errors * fixing cli errors * fix cli errors * fix cli errors * fixing cli errors * fix cli errors * fixing cli errors * fixing final cli error * updated file name etc. to PR number * Fixing markdown linter errors @Pandapip1 -- the issue is now the same with inline HTM as with ethereum#6843. Please, approve if this is ok. I had asked @lightclient for an alternative to make individual requirements referenceable through a URL, apart from inline or using ##### which is not allowed either. * fixing some more markdown linter errors * fixing markdown linter errors * fixing one markdown error apart from inline * Commit from EIP-Bot * fixing unexplained file naming and EIP number errors * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Updates per request from @SamWilsn * correcting CI issues * fixed error in rfc links * fixing CI issues * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * Update EIPS/eip-6734.md Co-authored-by: Sam Wilson <[email protected]> * updating PRs based on @SamWilsn requests * Update EIPS/eip-6734.md --------- Co-authored-by: eth-bot <[email protected]> Co-authored-by: Sam Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: