Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP: L2 Token List #6734

Merged
merged 39 commits into from
Sep 13, 2023
Merged

Add EIP: L2 Token List #6734

merged 39 commits into from
Sep 13, 2023

Conversation

Therecanbeonlyone1969
Copy link
Contributor

@Therecanbeonlyone1969 Therecanbeonlyone1969 commented Mar 20, 2023 •
edited by github-actions bot
Loading

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@github-actions github-actions bot added c-new Creates a brand new proposal e-number Waiting on EIP Number assignment s-draft This EIP is a Draft t-erc labels Mar 20, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Mar 20, 2023 •
edited
Loading

File EIPS/eip-6734.md

Requires 1 more reviewers from @axic, @Pandapip1, @SamWilsn, @xinbenlv

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Mar 20, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Mar 20, 2023
@poojaranjan poojaranjan mentioned this pull request Mar 21, 2023
Closed
25 tasks
@eth-bot eth-bot changed the title Initial submission of L2 Token List Draft Add EIP: Mar 22, 2023
@eth-bot eth-bot changed the title Add EIP: Add EIP: undefined Mar 22, 2023
@Pandapip1
Copy link
Member

@eth-bot rerun

@eth-bot eth-bot changed the title Add EIP: undefined Add EIP: L2 Token List Mar 22, 2023
Pandapip1
Pandapip1 suggested changes Mar 22, 2023
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI errors.

@github-actions github-actions bot removed the e-number Waiting on EIP Number assignment label Mar 22, 2023
@github-actions github-actions bot removed c-new Creates a brand new proposal w-ci Waiting on CI to pass labels Mar 22, 2023
@github-actions github-actions bot added c-new Creates a brand new proposal e-number Waiting on EIP Number assignment w-ci Waiting on CI to pass labels Mar 22, 2023
@github-actions github-actions bot removed c-new Creates a brand new proposal e-number Waiting on EIP Number assignment labels Mar 22, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jun 27, 2023
@Therecanbeonlyone1969
Copy link
Contributor Author

@SamWilsn only the NIST CVE link is giving problems. Can the Editors add the NIST NVD to the list of allowed references?

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jun 27, 2023
@poojaranjan poojaranjan mentioned this pull request Jul 11, 2023
Closed
15 tasks
SamWilsn
SamWilsn reviewed Jul 11, 2023
View reviewed changes
EIPS/eip-6734.md Outdated Show resolved Hide resolved
EIPS/eip-6734.md Outdated Show resolved Hide resolved
EIPS/eip-6734.md Outdated Show resolved Hide resolved
EIPS/eip-6734.md Outdated Show resolved Hide resolved
Therecanbeonlyone1969 and others added 2 commits July 31, 2023 10:43
@Therecanbeonlyone1969 @SamWilsn
Update EIPS/eip-6734.md
9c1bfa2 
Co-authored-by: Sam Wilson <[email protected]>
@Therecanbeonlyone1969 @SamWilsn
Update EIPS/eip-6734.md
dcdc2d4 
Co-authored-by: Sam Wilson <[email protected]>
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jul 31, 2023
@Therecanbeonlyone1969 @SamWilsn
Update EIPS/eip-6734.md
a646c4c 
Co-authored-by: Sam Wilson <[email protected]>
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jul 31, 2023
@Therecanbeonlyone1969
Copy link
Contributor Author

@SamWilsn addressed your requests. The last open item is to add NIST to the list of allowed URLs. Is there anything I need to in terms of the process to request that?

@Therecanbeonlyone1969 Therecanbeonlyone1969 mentioned this pull request Aug 7, 2023
Closed
21 tasks
@poojaranjan poojaranjan mentioned this pull request Aug 22, 2023
Closed
11 tasks
@SamWilsn
Copy link
Contributor

@SamWilsn addressed your requests. The last open item is to add NIST to the list of allowed URLs. Is there anything I need to in terms of the process to request that?

You'll need to open a pull request to EIP-1 to add it, following the guidelines in EIP-5757. I'll add it to tomorrow's EIPIP call to discuss.

@SamWilsn
Copy link
Contributor

#7542 <- pull request to allow links to NIST CVEs

@Therecanbeonlyone1969
Copy link
Contributor Author

#7542 <- pull request to allow links to NIST CVEs

@SamWilsn thank you so much!

SamWilsn
SamWilsn reviewed Sep 13, 2023
View reviewed changes
EIPS/eip-6734.md Outdated

## Security Considerations

There are no additional security requirements apart from the warnings that URIs utilized in implementations of this standard might be direct to malicious resources such as websites, and that implementers should ensure that data utilized for a canonical token list is secure and correct. Since this standard is focused on a data schema and its data properties there are no additional security considerations from for example homoglyph attacks (see [CVE-2021-42574](https://nvd.nist.gov/vuln/detail/CVE-2021-42574)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
There are no additional security requirements apart from the warnings that URIs utilized in implementations of this standard might be direct to malicious resources such as websites, and that implementers should ensure that data utilized for a canonical token list is secure and correct. Since this standard is focused on a data schema and its data properties there are no additional security considerations from for example homoglyph attacks (see [CVE-2021-42574](https://nvd.nist.gov/vuln/detail/CVE-2021-42574)).
There are no additional security requirements apart from the warnings that URIs utilized in implementations of this standard might be direct to malicious resources such as websites, and that implementers should ensure that data utilized for a canonical token list is secure and correct. Since this standard is focused on a data schema and its data properties there are no additional security considerations from for example homoglyph attacks (see [CVE-2021-42574 (2021-10-25T12:38:28)](https://nvd.nist.gov/vuln/detail/CVE-2021-42574)).

Until eipw is updated to support links to CVEs, all pull requests to this EIP will require a manual merge. Sorry about the inconvenience!

@SamWilsn SamWilsn merged commit 2f68e7d into ethereum:master Sep 13, 2023
7 of 9 checks passed
@github-actions
Copy link

The commit 4982606 (as a parent of a3763bc) contains errors.
Please inspect the Run Summary for details.

streamnft-tech pushed a commit to streamnft-tech/EIPs that referenced this pull request Oct 27, 2023
@Therecanbeonlyone1969 @eth-bot @SamWilsn
Add EIP: L2 Token List (ethereum#6734)
8c77b3b 
* Initial submission of L2 Token List Draft

* updated headers (cut and paste error)

* fixing cli errors

* fixing cli errors

* fix cli errors

* fixing cli errors

* fixing cli errors

* fix cli errors

* fix cli errors

* fixing cli errors

* fix cli errors

* fixing cli errors

* fixing final cli error

* updated file name etc. to PR number

* Fixing markdown linter errors

@Pandapip1 -- the issue is now the same with inline HTM as with ethereum#6843.

Please, approve if this is ok.  I had asked @lightclient  for an alternative to make individual requirements referenceable through a URL, apart from inline or using ##### which is not allowed either.

* fixing some more markdown linter errors

* fixing markdown linter errors

* fixing one markdown error apart from inline

* Commit from EIP-Bot

* fixing unexplained file naming and EIP number errors

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Updates per request from @SamWilsn

* correcting CI issues

* fixed error in rfc links

* fixing CI issues

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* updating PRs based on @SamWilsn requests

* Update EIPS/eip-6734.md

---------

Co-authored-by: eth-bot <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
RaphaelHardFork pushed a commit to RaphaelHardFork/EIPs that referenced this pull request Jan 30, 2024
@Therecanbeonlyone1969 @eth-bot
@SamWilsn @RaphaelHardFork
Add EIP: L2 Token List (ethereum#6734)
36bb2d8 
* Initial submission of L2 Token List Draft

* updated headers (cut and paste error)

* fixing cli errors

* fixing cli errors

* fix cli errors

* fixing cli errors

* fixing cli errors

* fix cli errors

* fix cli errors

* fixing cli errors

* fix cli errors

* fixing cli errors

* fixing final cli error

* updated file name etc. to PR number

* Fixing markdown linter errors

@Pandapip1 -- the issue is now the same with inline HTM as with ethereum#6843.

Please, approve if this is ok.  I had asked @lightclient  for an alternative to make individual requirements referenceable through a URL, apart from inline or using ##### which is not allowed either.

* fixing some more markdown linter errors

* fixing markdown linter errors

* fixing one markdown error apart from inline

* Commit from EIP-Bot

* fixing unexplained file naming and EIP number errors

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Updates per request from @SamWilsn

* correcting CI issues

* fixed error in rfc links

* fixing CI issues

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* updating PRs based on @SamWilsn requests

* Update EIPS/eip-6734.md

---------

Co-authored-by: eth-bot <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
just-a-node pushed a commit to connext/EIPs that referenced this pull request Feb 17, 2024
@Therecanbeonlyone1969 @eth-bot
@SamWilsn @just-a-node
Add EIP: L2 Token List (ethereum#6734)
36684cd 
* Initial submission of L2 Token List Draft

* updated headers (cut and paste error)

* fixing cli errors

* fixing cli errors

* fix cli errors

* fixing cli errors

* fixing cli errors

* fix cli errors

* fix cli errors

* fixing cli errors

* fix cli errors

* fixing cli errors

* fixing final cli error

* updated file name etc. to PR number

* Fixing markdown linter errors

@Pandapip1 -- the issue is now the same with inline HTM as with ethereum#6843.

Please, approve if this is ok.  I had asked @lightclient  for an alternative to make individual requirements referenceable through a URL, apart from inline or using ##### which is not allowed either.

* fixing some more markdown linter errors

* fixing markdown linter errors

* fixing one markdown error apart from inline

* Commit from EIP-Bot

* fixing unexplained file naming and EIP number errors

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Updates per request from @SamWilsn

* correcting CI issues

* fixed error in rfc links

* fixing CI issues

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* updating PRs based on @SamWilsn requests

* Update EIPS/eip-6734.md

---------

Co-authored-by: eth-bot <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
@Therecanbeonlyone1969 @eth-bot
@SamWilsn @GAEAlimited
Add EIP: L2 Token List (ethereum#6734)
fc7dda2 
* Initial submission of L2 Token List Draft

* updated headers (cut and paste error)

* fixing cli errors

* fixing cli errors

* fix cli errors

* fixing cli errors

* fixing cli errors

* fix cli errors

* fix cli errors

* fixing cli errors

* fix cli errors

* fixing cli errors

* fixing final cli error

* updated file name etc. to PR number

* Fixing markdown linter errors

@Pandapip1 -- the issue is now the same with inline HTM as with ethereum#6843.

Please, approve if this is ok.  I had asked @lightclient  for an alternative to make individual requirements referenceable through a URL, apart from inline or using ##### which is not allowed either.

* fixing some more markdown linter errors

* fixing markdown linter errors

* fixing one markdown error apart from inline

* Commit from EIP-Bot

* fixing unexplained file naming and EIP number errors

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Updates per request from @SamWilsn

* correcting CI issues

* fixed error in rfc links

* fixing CI issues

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* updating PRs based on @SamWilsn requests

* Update EIPS/eip-6734.md

---------

Co-authored-by: eth-bot <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
blacksnow2 pushed a commit to blacksnow2/EIPs that referenced this pull request Jul 21, 2024
@Therecanbeonlyone1969 @eth-bot
@SamWilsn @blacksnow2
Add EIP: L2 Token List (ethereum#6734)
8dc0a2d 
* Initial submission of L2 Token List Draft

* updated headers (cut and paste error)

* fixing cli errors

* fixing cli errors

* fix cli errors

* fixing cli errors

* fixing cli errors

* fix cli errors

* fix cli errors

* fixing cli errors

* fix cli errors

* fixing cli errors

* fixing final cli error

* updated file name etc. to PR number

* Fixing markdown linter errors

@Pandapip1 -- the issue is now the same with inline HTM as with ethereum#6843.

Please, approve if this is ok.  I had asked @lightclient  for an alternative to make individual requirements referenceable through a URL, apart from inline or using ##### which is not allowed either.

* fixing some more markdown linter errors

* fixing markdown linter errors

* fixing one markdown error apart from inline

* Commit from EIP-Bot

* fixing unexplained file naming and EIP number errors

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Updates per request from @SamWilsn

* correcting CI issues

* fixed error in rfc links

* fixing CI issues

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* Update EIPS/eip-6734.md

Co-authored-by: Sam Wilson <[email protected]>

* updating PRs based on @SamWilsn requests

* Update EIPS/eip-6734.md

---------

Co-authored-by: eth-bot <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWilsn SamWilsn SamWilsn left review comments

@abcoathup abcoathup abcoathup left review comments

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

@Pandapip1 Pandapip1 Awaiting requested review from Pandapip1

Assignees
No one assigned
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-erc w-ci Waiting on CI to pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Therecanbeonlyone1969 @eth-bot @Pandapip1 @SamWilsn @abcoathup