Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-1898: Move to draft #5980

Merged
merged 6 commits into from
Nov 20, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
discussions-to
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
macfarla committed Nov 16, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 354c1ba9518af540632e50394ebdefadb1e60cc3
13 changes: 5 additions & 8 deletions EIPS/eip-1898.md
Original file line number Diff line number Diff line change
@@ -3,9 +3,10 @@ eip: 1898
title: Add `blockHash` to defaultBlock methods
description: Add `blockHash` option to JSON-RPC methods that currently support defaultBlock parameter.
author: Charles Cooper (@charles-cooper)
category: Interface
discussions-to: https://ethereum-magicians.org/t/eip-1898-add-blockhash-option-to-json-rpc-methods-that-currently-support-defaultblock-parameter/11757
status: Draft
type: Standards Track
category: Interface
created: 2019-04-01
requires: 234, 1474
macfarla marked this conversation as resolved.
Show resolved Hide resolved
---
@@ -69,10 +70,6 @@ Allowing `eth_call` and friends to unambiguously specify the block to be queried

Backwards compatible.

## Security Considerations

None

## Test Cases

- `eth_getStorageAt [ "0x<address>", { "blockNumber": "0x0" }` -> return storage at given address in genesis block
@@ -86,10 +83,10 @@ None
- `eth_getStorageAt [ "0x<address>", { "blockHash": "0x<non-canonical-block-hash>", "requireCanonical": false }` -> return storage at given address in specified block
- `eth_getStorageAt [ "0x<address>", { "blockHash": "0x<non-canonical-block-hash>", "requireCanonical": true }` -> raise block-not-canonical error

## Implementation
## Security Considerations

None

It is supported by Geth 1.9.6 ([PR](https://github.com/ethereum/go-ethereum/pull/19491)).
It is supported by Besu 20.10.4 ([PR]https://github.com/hyperledger/besu/pull/1784)

## Copyright