Update EIP-1898: Move to draft #5980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sally MacFarlane <[email protected]>
github-actions
bot
added
c-status
|
A critical exception has occurred: |
This was referenced Nov 16, 2022
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
charles-cooper
previously approved these changes
Nov 16, 2022
|
This could probably be moved to review or final stage. It has been implemented and stable in clients for years now. |
Thanks @charles-cooper - changed to Review |
Signed-off-by: Sally MacFarlane <[email protected]>
github-actions
bot
added
s-review
macfarla
changed the title
Pandapip1
changed the title
Pandapip1
reviewed
Nov 16, 2022
Pandapip1
reviewed
Nov 16, 2022
Signed-off-by: Sally MacFarlane <[email protected]>
github-actions
bot
added
s-draft
macfarla
changed the title
charles-cooper
approved these changes
Nov 16, 2022
|
opened a separate PR for moving EIP-1474 back to draft also #5986 |
|
LGTM: the author approved and the update seems reasonable, agree to move back to Draft. In terms of moving to Review -> Final, I love to see if we can accelerate that process if this EIP have been stable and implemented by clients. Editors to discuss |
6 tasks
Pandapip1
approved these changes
Nov 20, 2022
eth-bot
approved these changes
Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sally MacFarlane [email protected]
It is supported by Geth 1.9.6 (PR).
It is supported by Besu 20.10.4 (PR).
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: