Update EIP-721: Use latest version of solidity and remove caveats #5887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
All tests passed; auto-merging...(pass) eip-721.md
|
fulldecent
approved these changes
Nov 7, 2022
eth-bot
approved these changes
Nov 7, 2022
SamWilsn
reviewed
Nov 11, 2022
| @@ -41,12 +41,12 @@ The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "S | |||
| **Every ERC-721 compliant contract must implement the `ERC721` and `ERC165` interfaces** (subject to "caveats" below): | |||
|
|
|||
| ```solidity | |||
| pragma solidity ^0.4.20; | |||
| pragma solidity ^0.8.17; | |||
There was a problem hiding this comment.
In safeTransferFrom:
TypeError: Data location must be "memory" or "calldata" for parameter in external function, but none was given.
SamWilsn
requested changes
Nov 11, 2022
There was a problem hiding this comment.
I am not sure that these changes "correct errata [or] add non-normative clarifications":
- The caveats section still applies for Solidity 0.4.20, so these changes aren't errata.
- Removing the caveats section obviously isn't adding clarifications.
I'd recommend that we discuss this on EIPIP.
|
This adds a non-normative clarification: an outdated version of solidity is removed, and a new version is added. To make this work, an outdated section describing the limitations of an old version of solidity has to removed - an additional clarification that is added. These are clarifications that are added to EIP-721, even though they remove stuff. |
|
Lets discuss on discord/EIPIP. |
7 tasks
|
Closing as per discussion in EIPIP. If you'd like to continue discussion, feel free to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the caveats mentioned in the EIP have been implemented in solidity. Thus, they are no longer relevant if the solidity version is updated to the most recent one.