Add EIP-5827: Auto-renewable allowance extension #5827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-new
|
A critical exception has occurred: |
github-actions
bot
removed
c-new
zlace0x
changed the title
github-actions
bot
added
c-new
Pandapip1
changed the title
Pandapip1
suggested changes
Oct 25, 2022
Co-authored-by: Pandapip1 <[email protected]>
ghost
suggested changes
Oct 26, 2022
ghost
suggested changes
Oct 26, 2022
ghost
suggested changes
Oct 26, 2022
|
#Please explain more, I don't understand |
feat: change recoveryRate to uint256
refactor: rename event, function, change recoveryRate type & additional interfaces
- avoid acronyms that may be unfamiliar to audience - reword sentences to flow better
- make them actually work - split lines where required so max width is 100 chars - prose fixes - indentation
e.g. token allowance revocation tools
and fix typo in param name
fix: style/syntax, natspec in interfaces
(kind of weird, though...)
…tion fix: add Markdown link to first mention of EIP-5827
Pandapip1
approved these changes
Nov 16, 2022
eth-bot
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.