Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP-5827: Auto-renewable allowance extension #5827

Merged
merged 32 commits into from
Nov 16, 2022
Merged

Add EIP-5827: Auto-renewable allowance extension #5827

merged 32 commits into from
Nov 16, 2022

Commits on Oct 25, 2022

  1. feat: add EIP-5824

    @zlace0x
    zlace0x committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    df240f7 View commit details
    Browse the repository at this point in the history

  2. chore: update title

    @zlace0x
    zlace0x committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    90f93c5 View commit details
    Browse the repository at this point in the history

  3. chore: update links

    @zlace0x
    zlace0x committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    12e94b2 View commit details
    Browse the repository at this point in the history

  4. fix: EIP number, relative links

    @zlace0x
    zlace0x committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    e1f76cf View commit details
    Browse the repository at this point in the history

  5. fix: added renamed file

    @zlace0x
    zlace0x committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    2416d98 View commit details
    Browse the repository at this point in the history

  6. fix: add EIP-20 reference

    @zlace0x
    zlace0x committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    4562bb0 View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: Pandapip1 <[email protected]>
    @zlace0x @Pandapip1
    zlace0x and Pandapip1 authored Oct 25, 2022
    Configuration menu
    Copy the full SHA
    324131c View commit details
    Browse the repository at this point in the history

  8. feat: keep interface optionally separated from EIP-20

    @zlace0x
    zlace0x committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    ad0e6af View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Neuti Yoo <[email protected]>
    @zlace0x
    zlace0x and Neuti Yoo authored Oct 26, 2022
    Configuration menu
    Copy the full SHA
    e34f13d View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. feat: add optional interfaces

    @zlace0x
    zlace0x committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    961610d View commit details
    Browse the repository at this point in the history

  2. refactor: renamed event and approve functions

    @zlace0x
    zlace0x committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    4a1cf7c View commit details
    Browse the repository at this point in the history

  3. refactor: added more functions to ERC165 hash

    @zlace0x
    zlace0x committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    f08a8ee View commit details
    Browse the repository at this point in the history

  4. refactor: comment styles

    @zlace0x
    zlace0x committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    98ea468 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. fix: added expiration to query function

    @zlace0x
    zlace0x committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    bd06f37 View commit details
    Browse the repository at this point in the history

  2. feat: change recoveryRate to uint256

    @zlace0x
    zlace0x committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    bf4b6ed View commit details
    Browse the repository at this point in the history

  3. feat: added ERC165 hashes

    @zlace0x
    zlace0x committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    0182646 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #3 from zlace0x/feat/uint256-recovery 

    feat: change recoveryRate to uint256
    @zlace0x
    zlace0x authored Oct 28, 2022
    Configuration menu
    Copy the full SHA
    31bf394 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #2 from zlace0x/feat/refactor-rename 

    refactor: rename event, function, change recoveryRate type & additional interfaces
    @zlace0x
    zlace0x authored Oct 28, 2022
    Configuration menu
    Copy the full SHA
    d66419f View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/master'

    @zlace0x
    zlace0x committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    5e26de2 View commit details
    Browse the repository at this point in the history

  7. fix: trailing space, added requirement

    @zlace0x
    zlace0x committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    d9ead5b View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. feat: added insufficient allowance error, clarified transfer event

    @zlace0x
    zlace0x committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    4ae57a1 View commit details
    Browse the repository at this point in the history

  2. fix: linter

    @zlace0x
    zlace0x committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    a997a97 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. fix: replace fancy double-quotes with u+22

    @zhongfu
    zhongfu committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    dda0a39 View commit details
    Browse the repository at this point in the history

  2. fix: prose style 

    - avoid acronyms that may be unfamiliar to audience
- reword sentences to flow better
    @zhongfu
    zhongfu committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    4ecfaae View commit details
    Browse the repository at this point in the history

  3. fix: fix natspec docs in interfaces 

    - make them actually work
- split lines where required so max width is 100 chars
- prose fixes
- indentation
    @zhongfu
    zhongfu committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    7c2d6c3 View commit details
    Browse the repository at this point in the history

  4. feat: add new security consideration about non-EIP-5827-aware apps 

    e.g. token allowance revocation tools
    @zhongfu
    zhongfu committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    26f9138 View commit details
    Browse the repository at this point in the history

  5. fix: specify that the extensions should extend IERC5827 too

    @zhongfu
    zhongfu committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    e9b7a7f View commit details
    Browse the repository at this point in the history

  6. fix: clarify possibly awkward expression 

    and fix typo in param name
    @zhongfu
    zhongfu authored Nov 3, 2022
    Configuration menu
    Copy the full SHA
    2f1990f View commit details
    Browse the repository at this point in the history

  7. Merge pull request #4 from zlace0x/fix/style-and-syntax 

    fix: style/syntax, natspec in interfaces
    @zlace0x
    zlace0x authored Nov 3, 2022
    Configuration menu
    Copy the full SHA
    9d10067 View commit details
    Browse the repository at this point in the history

  8. fix: add Markdown link to first mention of EIP-5827 

    (kind of weird, though...)
    @zhongfu
    zhongfu committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    fb87f37 View commit details
    Browse the repository at this point in the history

  9. Merge pull request #5 from zlace0x/fix/markdown-link-on-first-eip-men… 

    …tion

fix: add Markdown link to first mention of EIP-5827
    @zlace0x
    zlace0x authored Nov 3, 2022
    Configuration menu
    Copy the full SHA
    3184a9d View commit details
    Browse the repository at this point in the history

  10. fix: "MUST not" -> "MUST NOT"

    @zhongfu
    zhongfu committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    e1f80fa View commit details
    Browse the repository at this point in the history