Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sep/027: upgrade and re-initialize SystemConfig across sepolia superchain #418

Merged
merged 77 commits into from
Jan 13, 2025
Merged

sep/027: upgrade and re-initialize SystemConfig across sepolia superchain #418

merged 77 commits into from
Jan 13, 2025
+888 −4

Conversation

geoknee
Copy link
Contributor

@geoknee geoknee commented Dec 17, 2024 •
edited
Loading

Closes #394

See also #454

TODO

  • upgrade to a multi chain task when things are working for OP Sepolia
  • add some breadcrumbs to the previous task 020 to signify that it was incorrect and that this task supercedes it
  • Build on top of @sebastianst 's new validation framework 3591eec

@geoknee geoknee changed the title first pass at task sep 025 Sep 026: upgrade and re-initialize SystemConfig Dec 17, 2024
@geoknee geoknee mentioned this pull request Dec 17, 2024
Merged
3 tasks
@geoknee geoknee changed the title Sep 026: upgrade and re-initialize SystemConfig Sep 027: upgrade and re-initialize SystemConfig Dec 18, 2024
@geoknee geoknee force-pushed the gk/025-holocene-sys-cfg branch 2 times, most recently from 50aeb48 to 2e881b4 Compare December 19, 2024 14:58
geoknee added 21 commits January 4, 2025 00:07
@geoknee
first pass at task sep 025
e5623ea
@geoknee
bump task index
14500b8 
existing task in flight for 025
@geoknee
undo change to submodule
9c83d58
@geoknee
add exceptions for EOAs in SystemConfig storage
cc782b3
@geoknee
bump task sequence number
dcd607c
@geoknee
change validation script to use Seb's new framework
c04293c
@geoknee
addAllowedStorageAccess for each system config
eb21f18
@geoknee
SystemConfigUpgrade exposes code exceptions thru getter
4014438
@geoknee
introduce SystemConfigUpgradeEcotoneScalars
fcda94c
@geoknee
add deprecation notice to task 020
d130513
@geoknee
remove unecessary forge build commands
ef18399 
Closes #423
@geoknee
add some logging
35b4718
@geoknee
reactivate all chains
1355535
@geoknee
update to superbundle
bb163d9
@geoknee
TEMP: do not try to load all contract addresses (some chains do not h…
0b39283 
…ave them, e.g. metal)
@geoknee
improve err msg
85aac3a
@geoknee
fix superbundle
ca3699e
@geoknee
use dynamic storage array
7b7f0d1
@geoknee
validate in a smarter way for chains migrating from pre ecotone scalars
80aa1cc
@geoknee
SuperchainRegistry: instead of skipping missing addresses globally, s…
7e0c7fe 
…kip only if not found in the TOML file
@geoknee
update overview and readme
127d370
sebastianst
sebastianst reviewed Jan 10, 2025
View reviewed changes
Copy link
Member

@sebastianst sebastianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the new upgrade check script! Will run a validation next.

script/verification/HoloceneSystemConfigUpgrade.s.sol Outdated Show resolved Hide resolved
script/verification/HoloceneSystemConfigUpgrade.s.sol Outdated Show resolved Hide resolved
script/verification/HoloceneSystemConfigUpgrade.s.sol Outdated Show resolved Hide resolved
script/verification/HoloceneSystemConfigUpgrade.s.sol Outdated Show resolved Hide resolved
tasks/sep/027-holocene-system-config-upgrade-and-init-multi-chain/NestedSignFromJson.s.sol Show resolved Hide resolved
tasks/sep/027-holocene-system-config-upgrade-and-init-multi-chain/VALIDATION.md Show resolved Hide resolved
tasks/sep/027-holocene-system-config-upgrade-and-init-multi-chain/VALIDATION.md Outdated Show resolved Hide resolved
sebastianst
sebastianst reviewed Jan 13, 2025
View reviewed changes
script/verification/HoloceneSystemConfigUpgrade.s.sol Outdated Show resolved Hide resolved
lib/forge-std Outdated Show resolved Hide resolved
sebastianst
sebastianst previously approved these changes Jan 13, 2025
View reviewed changes
Ethnical
Ethnical requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@Ethnical Ethnical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation state is now incorrect with the nonce.

@geoknee geoknee enabled auto-merge January 13, 2025 15:26
@geoknee geoknee added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit 31fb049 Jan 13, 2025
17 checks passed
@geoknee geoknee deleted the gk/025-holocene-sys-cfg branch January 13, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mds1 mds1 mds1 left review comments

@Ethnical Ethnical Ethnical approved these changes

@sebastianst sebastianst sebastianst left review comments

@smartcontracts smartcontracts Awaiting requested review from smartcontracts smartcontracts is a code owner automatically assigned from ethereum-optimism/contract-reviewers

Assignees

@Ethnical Ethnical

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in SystemConfig Holocene Upgrade
4 participants
@geoknee @sebastianst @mds1 @Ethnical