Sep 027: upgrade and re-initialize SystemConfig
#418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoknee
changed the title
SystemConfig
3 tasks
geoknee
commented
Dec 17, 2024
| - All addresses (in section headers and storage values) match the provided name, using the Etherscan and Superchain Registry links provided. This validates the bytecode deployed at the addresses contains the correct logic. | ||
| - All key values match the semantic meaning provided, which can be validated using the storage layout links provided. | ||
|
|
||
| ## State Changes |
There was a problem hiding this comment.
This should also ideally show the baseFeeScalar and blobbaseFeeScalar changes.
geoknee
changed the title
SystemConfig SystemConfig
geoknee
force-pushed
the
gk/025-holocene-sys-cfg
branch
from
b7e7f3c to
33d9359
Compare
existing task in flight for 025
geoknee
force-pushed
the
gk/025-holocene-sys-cfg
branch
from
50aeb48 to
2e881b4
Compare
sebastianst
reviewed
Dec 19, 2024
tasks/sep/027-holocene-system-config-upgrade-and-init-multi-chain/NestedSignFromJson.s.sol
Outdated
Show resolved
Hide resolved
tasks/sep/027-holocene-system-config-upgrade-and-init-multi-chain/NestedSignFromJson.s.sol
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
020to signify that it was incorrect and that this task supercedes itCloses #394