respond to review comments

ethereum-optimism · Jan 10, 2025 · c5da1ab · c5da1ab
1 parent ef7ccef
commit c5da1ab
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/script/verification/HoloceneSystemConfigUpgrade.s.sol b/script/verification/HoloceneSystemConfigUpgrade.s.sol
@@ -107,10 +107,7 @@ contract HoloceneSystemConfigUpgrade is SuperchainRegistry {
 
     // Checks semver of SystemConfig is correct after the upgrade
     function checkTargetVersion() internal view {
-        require(
-            keccak256(abi.encode(getSysCfgVersion())) == keccak256(abi.encode(targetVersion)),
-            "system-config-050: targetVersion"
-        );
+        require(getSysCfgVersion().eq(targetVersion), "system-config-050: targetVersion");
         console.log("confirmed SystemConfig upgraded to version", targetVersion);
     }
 

diff --git a/script/verification/Verification.s.sol b/script/verification/Verification.s.sol
@@ -4,9 +4,8 @@ pragma solidity ^0.8.15;
 import {console2 as console} from "forge-std/console2.sol";
 import {LibString} from "solady/utils/LibString.sol";
 import {Types} from "@eth-optimism-bedrock/scripts/Types.sol";
-import {ScriptBase} from "forge-std/Base.sol";
+import {CommonBase} from "forge-std/Base.sol";
 import {stdToml} from "forge-std/StdToml.sol";
-import {console2 as console} from "forge-std/console2.sol";
 
 // TODO(#427): Proposing to just merge this contract into JsonTxBuilderBase.
 contract VerificationBase {
@@ -22,7 +21,7 @@ contract VerificationBase {
     }
 }
 
-contract SuperchainRegistry is ScriptBase {
+contract SuperchainRegistry is CommonBase {
     using LibString for string;
 
     struct StandardVersion {