holocene: add rule to limit channel size at channel stage #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 15, 2024
sebastianst
force-pushed
the
seb/holocene-channel-max-size
branch
from
ae5463e
to
b2538e7
Compare
protolambda
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds rule to limit channel size at channel stage by
MaxRLPBytesPerChannel. This replaces the limit of all channels' sizes byMaxChannelBankSize.Additional context
This rule makes sense since the channel stage now only holds a single (still compressed) channel, so it can be limited in size by the later limit on an uncompressed channel. Compression is none worst-case (ignoring overheads), so practically this doesn't add any stronger limits on a channel, but early-limits the size by which the channel bank could grow, back to 100 MB from 1 GB, since the channel bank size was increased to 1GB with Fjord.