feat(derive): Add ChannelAssembler size limitation
#700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clabby
added
K-feature
clabby
force-pushed
the
cl/channel-assembler-size-limit
branch
5 times, most recently
from
e52b256
to
7621068
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
clabby
force-pushed
the
cl/channel-assembler-size-limit
branch
5 times, most recently
from
7621068
to
2e0752f
Compare
clabby
force-pushed
the
cl/channel-assembler-size-limit
branch
6 times, most recently
from
1fe0baa
to
80fd9a0
Compare
clabby
force-pushed
the
cl/channel-assembler-size-limit
branch
from
80fd9a0
to
4050a5c
Compare
refcell
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Note
Needs #702
Adds a check for maximum channel size to the
ChannelAssemblerstage, which enforces that the channel being built never exceedsMAX_RLP_BYTES_PER_CHANNEL. This update is according to the recent update to the Holocene spec hereCloses #698