Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

holocene: fix frame queue specs of derivation #386

Merged
merged 1 commit into from
Sep 24, 2024
Merged

holocene: fix frame queue specs of derivation #386

merged 1 commit into from
Sep 24, 2024

Conversation

sebastianst
Copy link
Member

Description

Applies two fixes to the Holocene derivation specs:

  • Actually allow non-first frames at the start of the queue! It is otherwise impossible to build up a channel with multiple transactions.
  • Clarify that a frame is also out of order if it belongs to the same channel as the previous frame, but its frame number is not an increment of the previous one.

Additional Context

This became clear during implementation of the specs at ethereum-optimism/optimism#12069

@sebastianst sebastianst merged commit d68c5cf into main Sep 24, 2024
1 check passed
@sebastianst sebastianst deleted the seb/holocene-fix-frame-queue branch September 24, 2024 09:01
blmalone pushed a commit that referenced this pull request Sep 26, 2024
@sebastianst @blmalone
holocene: fix frame queue specs of derivation (#386)
3e0555c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refcell refcell refcell approved these changes

@protolambda protolambda protolambda approved these changes

@ajsutton ajsutton Awaiting requested review from ajsutton ajsutton is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebastianst @protolambda @refcell