-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-node/rollup/derive: Implement Holocene Frame Queue #12069
Conversation
e310338
to
1abd736
Compare
a4a7771
to
5e16647
Compare
Semgrep found 2 TODO in error handling code Ignore this finding from err-todo.Semgrep found 35
Named return arguments to functions must be appended with an underscore ( Semgrep found 46
Inputs to functions must be prepended with an underscore ( |
Semgrep found 2
Inputs to functions must be prepended with an underscore ( |
5e16647
to
aee09fd
Compare
aee09fd
to
5c17bf1
Compare
I've come here to say I like the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Really good to see unit tests being added for this. Have suggested a few nits and you got some Friday afternoon grumbling - sorry. But looks good overall. :)
Description
Implements the Holocene Frame Queue according to the specs.
Tests
Added unit tests of the new frame queue pruning function, and the
FrameQueue
itself.Metadata