Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node/rollup/derive: Implement Holocene Frame Queue #12069

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

sebastianst
Copy link
Member

@sebastianst sebastianst commented Sep 23, 2024

Description

Implements the Holocene Frame Queue according to the specs.

Tests

Added unit tests of the new frame queue pruning function, and the FrameQueue itself.

Metadata

Copy link
Contributor

semgrep-app bot commented Sep 26, 2024

Semgrep found 2 err-todo findings:

TODO in error handling code

Ignore this finding from err-todo.

Semgrep found 35 sol-style-return-arg-fmt findings:

Named return arguments to functions must be appended with an underscore (_)

Ignore this finding from sol-style-return-arg-fmt.

Semgrep found 46 sol-style-input-arg-fmt findings:

Inputs to functions must be prepended with an underscore (_)

Ignore this finding from sol-style-input-arg-fmt.

Copy link
Contributor

semgrep-app bot commented Sep 26, 2024

Semgrep found 2 sol-style-input-arg-fmt findings:

  • packages/contracts-bedrock/src/L1/OPContractsManagerInterop.sol
  • packages/contracts-bedrock/src/L1/OPContractsManager.sol

Inputs to functions must be prepended with an underscore (_)

Ignore this finding from sol-style-input-arg-fmt.

@refcell
Copy link
Contributor

refcell commented Sep 26, 2024

I've come here to say I like the op-node/rollup/derive: PR prefix. This makes it easy for me to understand what this PR intends to touch.

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Really good to see unit tests being added for this. Have suggested a few nits and you got some Friday afternoon grumbling - sorry. But looks good overall. :)

op-node/rollup/derive/frame_queue.go Show resolved Hide resolved
op-node/rollup/derive/frame_queue.go Outdated Show resolved Hide resolved
op-node/rollup/derive/frame_queue.go Outdated Show resolved Hide resolved
op-node/rollup/derive/frame_queue.go Show resolved Hide resolved
op-node/rollup/derive/frame_queue_test.go Outdated Show resolved Hide resolved
op-node/rollup/derive/frame_queue_test.go Outdated Show resolved Hide resolved
op-node/rollup/derive/frame_queue_test.go Outdated Show resolved Hide resolved
@sebastianst sebastianst added this pull request to the merge queue Sep 27, 2024
Merged via the queue into develop with commit 6b2a3fe Sep 27, 2024
64 checks passed
@sebastianst sebastianst deleted the seb/holocene-frame-queue branch September 27, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Holocene-D: Implement strict frame ordering across batcher transactions
5 participants