Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: always run sync tests #989

Closed
wants to merge 3 commits into from
Closed

test: always run sync tests #989

wants to merge 3 commits into from

Conversation

gakonst
Copy link
Contributor

@gakonst gakonst commented May 31, 2021

Enables running the sync tests introduced in #913 on CI by moving them under the test/ directory.

@gakonst gakonst requested a review from tynes as a code owner May 31, 2021 13:46
@changeset-bot
Copy link

changeset-bot bot commented May 31, 2021

⚠️ No Changeset found

Latest commit: 47a4a1a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gakonst gakonst requested a review from annieke May 31, 2021 13:52
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2021

Codecov Report

Merging #989 (47a4a1a) into develop (5a79849) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #989   +/-   ##
========================================
  Coverage    82.21%   82.21%           
========================================
  Files           48       48           
  Lines         1895     1895           
  Branches       303      303           
========================================
  Hits          1558     1558           
  Misses         337      337           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a79849...47a4a1a. Read the comment docs.

@platocrat
Copy link
Contributor

i'm updating the branch here

@tynes
Copy link
Contributor

tynes commented Jun 1, 2021

I like the idea but it looks like the path to the docker-compose.yml is incorrect

Copy link
Contributor

@annieke annieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is where i want to eventually move to! i think 2 issues right now:

  1. running the tests in docker also gives me this spawn docker-compose ENOENT error locally, which i think is from trying to use docker-compose within docker. haven't tried too hard to debug it, because
  2. sync tests will always fail when ran with integration tests right now, since erc20 deploys + transfers produce mismatched stateroots
    so as of now the simplest way is still to run sync tests in their own workflow, i'll try out the other solution to see if it's faster feat[ci]: parallelize integration, example, and sync tests #972 (comment)

@gakonst gakonst closed this Jun 2, 2021
@gakonst
Copy link
Contributor Author

gakonst commented Jun 2, 2021

Closing given Annie is on it. I think we should figure out what causes the mismatched state roots before enabling the tests (independently of having it in the same or other workflow, since otherwise the test would give us false confidence)

@gakonst gakonst deleted the test/sync-tests branch June 3, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants