-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[ci]: parallelize integration, example, and sync tests #972
Conversation
|
Codecov Report
@@ Coverage Diff @@
## develop #972 +/- ##
========================================
Coverage 82.21% 82.21%
========================================
Files 48 48
Lines 1895 1895
Branches 303 303
========================================
Hits 1558 1558
Misses 337 337 Continue to review full report at Codecov.
|
9ab5bf4
to
9e352d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The work flows still take many minutes to run because the load-images step is not finding the tarballs
20659d3
to
9a048f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR does what we want, but it seems to be making things slower due to having to save/upload & download/load the images...If this does not improve our CI times let's hold on it. I've opened #989 to enable the sync tests on CI.
Curious if you considered using the caching strategy Docker proposes here? |
@snario just poked around some docs and i think for us to share images between jobs (necessary for parallelizing the tests), the uploading artifacts part is still necessary, and the caching just helps with the build part: docker/build-push-action#225 let me know if your investigations yield any further results! going to mark this as draft until then |
a9990f7
to
2e49a43
Compare
use yarn cache yarn before sync tests run build before test
rename jobs
add builder to saved images
2e49a43
to
480fef5
Compare
Description
Make integration testing more efficient by parallelizing the 3 test suites.
Additional context
following up on #913
Metadata