Isthmus: Updates for L2 withdrawals root in header #12848
Draft
+803
−231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📚
|
This was referenced Nov 6, 2024
vdamle
changed the title
* add withdrawalsRoot to ExecutionPayload. * add a `BlocksV4` topic to p2p gossip and check for non-empty withdrawalsRoot on v4 topic. * add checks for whether block is type v4 and apply relevant marshal/unmarshal for l2 withdrawals root.
* attributes check * outputV0AtBlock api update * minor type updates
and fixes for a few failures
when computing L2OutputRoot, no need to re-compute the storage root if Isthmus is active.
and fix lint errors
* `RPCResponseCheck` is an interface that currently has a function that validates withdrawals. * There's an implementation of this interface for L1 and L2 * L1's response checker validates that the withdrawals list matches the root in the header. * L2's response checker validates that the withdrawals list is empty when the withdrawalsRoot is not nil
will move to a separate PR
* test all combinations - with/without withdrawal transaction before, at and after isthmus
vdamle
force-pushed
the
vd/l2-withdrawals-root
branch
from
fc6b673 to
79609ed
Compare
vdamle
force-pushed
the
vd/isthmus-config
branch
from
bb28ebc to
2449a55
Compare
vdamle
commented
Nov 13, 2024
| @@ -250,7 +250,7 @@ require ( | |||
| rsc.io/tmplfunc v0.0.3 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/ethereum/go-ethereum v1.14.11 => github.com/ethereum-optimism/op-geth v1.101411.1-rc.6 | |||
| replace github.com/ethereum/go-ethereum v1.14.11 => ../op-geth | |||
There was a problem hiding this comment.
TODO - will be changed to use a commit tag, once the op-geth PR is approved/merged
raise a separate PR for it.
Also fix a test in rollup, with the correct expectation for sepolia holocene time
vdamle
commented
Dec 4, 2024
| @@ -386,6 +395,10 @@ func BuildBlocksValidator(log log.Logger, cfg *rollup.Config, runCfg GossipRunti | |||
| return pubsub.ValidationReject | |||
| } | |||
|
|
|||
| if blockVersion.HasWithdrawalsRoot() && payload.WithdrawalsRoot == nil { | |||
| log.Warn("payload is on v4 topic, but has nil withdrawals root", "bad_hash", payload.BlockHash.String()) | |||
There was a problem hiding this comment.
return error in addition to logging a warning here.
vdamle
commented
Dec 4, 2024
| return nil | ||
| // checkWithdrawals checks if the withdrawals list and withdrawalsRoot are as expected in the attributes and block, | ||
| // based on the active hard fork. | ||
| func checkWithdrawals(rollupCfg *rollup.Config, attrs *eth.PayloadAttributes, block *eth.ExecutionPayload) error { |
There was a problem hiding this comment.
Can we simplify the expression of these conditions?
vdamle
force-pushed
the
vd/isthmus-config
branch
from
2449a55 to
a011f49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR proposes changes to add:
L2ToL1MessagePassercontract to theExecutionPayload.v4) for Isthmus blocks.Tests
Are in a separate PR
Additional context
Addresses changes to Consensus Layer to support L2 withdrawals root in the block header, as outlined in #12044
Spec changes: ethereum-optimism/specs#394
EL changes:
Metadata
None.