Isthmus: Tests and misc updates for L2 withdrawals root #399

vdamle · 2024-10-09T05:56:18Z

Targeted to be merged into: #383

for TODO work items in op-geth documented in: ethereum-optimism/optimism#12044

beacon/engine/types.go

vdamle · 2024-10-25T20:45:14Z

@protolambda In order to update the genesis handling when reading from superchain-registry: https://github.com/ethereum-optimism/op-geth/blob/optimism/core/superchain.go#L30-L46 , I will need to make a change to SCR to:

become aware of Isthmus fork.
read the withdrawalsRoot from the genesis data, if Isthmus is active.

Going to work on that PR, so there's a TBD in op-geth to update that portion of the genesis after the SCR code is in.

core/rlp_test.go

core/types/block.go

core/genesis.go

core/types/block_test.go

core/types/transaction_conditional_test.go

beacon/types/exec_data_test.go

core/genesis.go

core/genesis_test.go

core/types/block.go

core/types/gen_header_json.go

core/genesis.go

vdamle · 2024-10-31T15:46:44Z

This comment is not relevant.

Because hashAlloc() reads the storage root of the contract, no change is needed in `superchain-registry. So the above comment can be ignored.

core/rlp_test.go

…thdrawals storage root

and update checks for l2 withdrawal root to be gated on Isthmus instead of Holocene

* To check whether Isthmus is active within NewBlock(), to appropriately handle withdrawalRoot, we need to pass in chainConfig. * Also added a Block RLP encode/decode test.

...of L2ToL1MessagePasser contract

ExecutableDataToBlockNoHash() needs to know whether Isthmus is active to determine the correct treatment of withdrawalsRoot

regenerating binding with go1.22 results in different unmarshalling code that fails existing tests

they were mainly to address vscode warnings, will move it to a separate PR

also removed usage of a 3rd party package and custom json tags in header.

* remove extra public api * change equality check for encode/decode roundtrip test * remove extra test which is covered already in fuzz test

* remove earlier hardcoded test added in block_test and revert other helper changes in block_test

to avoid import cycle and include all fuzz tests in a single place

protolambda

One change to make, then good to merge into the base branch. Will do another review there, and then with the monorepo side ready (don't want to block updates to latest op-geth due to breaking changes in block-construction signatures) we can merge it optimism branch.

core/genesis.go

beacon/engine/types.go

vdamle changed the title ~~Isthumus: Tests and miscellaneous updates for L2 withdrawals root~~ Isthumus: Tests and misc updates for L2 withdrawals root Oct 9, 2024

vdamle changed the title ~~Isthumus: Tests and misc updates for L2 withdrawals root~~ Isthmus: Tests and misc updates for L2 withdrawals root Oct 9, 2024

vdamle force-pushed the vd/l2-withdrawals-tests branch from f790bbd to d4998b0 Compare October 22, 2024 18:06

vdamle force-pushed the l2-withdrawals-root branch from 8d2f6ac to 823e2d9 Compare October 22, 2024 18:14

vdamle force-pushed the vd/l2-withdrawals-tests branch from d4998b0 to f56b4ca Compare October 22, 2024 18:21

vdamle commented Oct 25, 2024

View reviewed changes

beacon/engine/types.go Outdated Show resolved Hide resolved

vdamle marked this pull request as ready for review October 25, 2024 20:59

vdamle requested a review from a team as a code owner October 25, 2024 20:59

vdamle requested review from ajsutton and protolambda and removed request for a team October 25, 2024 20:59