refactor: remove superchain erc20 modifier #12566
Merged
+9
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: remove superchain erc20 modifier --------- Co-authored-by: Disco <[email protected]> Co-authored-by: 0xng <[email protected]> Co-authored-by: 0xParticle <[email protected]> Co-authored-by: gotzenx <[email protected]>
agusduha
changed the title
maurelian
approved these changes
Oct 22, 2024
|
cc @mslipper any idea what is wrong with CI in this PR? |
…erchain-modifier fix: merge develop to superchain modifier
Merged
via the queue into
ethereum-optimism:develop
with commit Oct 23, 2024
358dd3f
49 checks passed
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
* fix: remove superchain erc20 modifier (ethereum-optimism#111) * fix: remove superchain erc20 modifier --------- Co-authored-by: Disco <[email protected]> Co-authored-by: 0xng <[email protected]> Co-authored-by: 0xParticle <[email protected]> Co-authored-by: gotzenx <[email protected]> * fix: pre pr --------- Co-authored-by: Disco <[email protected]> Co-authored-by: 0xng <[email protected]> Co-authored-by: 0xParticle <[email protected]> Co-authored-by: gotzenx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
onlySuperchainTokenBridgefromSuperchainERC20and add the check line to the functions directly.Additional context
Rationale: #12514 (comment)
Metadata
Closes #12553