Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove onlySuperchainTokenBridge modifier from SuperchainERC20 #12553

Closed
gotzenx opened this issue Oct 21, 2024 · 2 comments · Fixed by #12566
Closed

Remove onlySuperchainTokenBridge modifier from SuperchainERC20 #12553

gotzenx opened this issue Oct 21, 2024 · 2 comments · Fixed by #12566
Assignees

Comments

@gotzenx
Copy link
Contributor

gotzenx commented Oct 21, 2024

As discussed with @mds1 on SuperchainWETH Redesign PR to follow on an internal best practice, we will not use modifiers if they dont have code before and after ;.

Change
Remove onlySuperchainTokenBridge from SuperchainERC20 and add the check line to the functions directly.

@tynes
Copy link
Contributor

tynes commented Oct 22, 2024

Could we also update the tenses of the events so that they match the spec in this PR?

@gotzenx
Copy link
Contributor Author

gotzenx commented Oct 22, 2024

Could we also update the tenses of the events so that they match the spec in this PR?

Yes, we already had this change ready but we were waiting on the SuperchainWETH Redesign to be merged.
Events changes PR: #12564

@tynes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants