Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up logging #115

Merged
merged 17 commits into from
Apr 29, 2020
Merged

Clean up logging #115

merged 17 commits into from
Apr 29, 2020

Conversation

masonforest
Copy link

Description

  • Add type checks for RPC call parameters
  • Concatenate logs onto a single line to reduce noise
  • Concatenate log parsing logs onto a single line

Metadata

Fixes

Contributing Agreement

willmeister
willmeister approved these changes Apr 28, 2020
View reviewed changes
Copy link

@willmeister willmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

Left a few comments, but this is awesome!

packages/core-utils/src/app/log.ts Outdated Show resolved Hide resolved
packages/ovm/src/app/utils.ts Outdated Show resolved Hide resolved
packages/ovm/src/app/utils.ts Outdated Show resolved Hide resolved
packages/rollup-full-node/src/app/web3-rpc-handler.ts Outdated
response = await this.blockNumber()
break
case Web3RpcMethods.call:
args = this.assertParameters(params, 2, latestBlock)
response = await this.call(args[0], args[1])
this.assertParameters(params, ['object', 'quantity|tag'])
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, I like this!

Might suggest an enum for types instead of string literals. If you make their values powers of two, bitwise operations will work seamlessly.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converted to enums 👍

It'd be awesome if we could make use of bitwise oring but I think that'd be a significant amount of work without much upside.

We'd have to pass "quantity | tag" into assertParameters as a parameter which you could do as either a bitmask or an array. Then we'd have to have branch in assertParameters and yada yada yada. Also there's only one case where things are ored together and very little chance others will be added. Happy to chat about it if you've got other ideas and wanna hop on a call though! 😀

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works! Didn't know how composable these would need to be. Looks like not very. This is a good pragmatic approach 👍

@masonforest masonforest force-pushed the YAS-322/Synthetix/LoggingUpdates branch from 05aab92 to 6aafe13 Compare April 28, 2020 15:47
@masonforest masonforest force-pushed the YAS-322/Synthetix/LoggingUpdates branch from 056f7df to 6e1bb65 Compare April 29, 2020 13:04
@masonforest masonforest force-pushed the YAS-322/Synthetix/LoggingUpdates branch from 0e699bc to 1022963 Compare April 29, 2020 13:12
@masonforest masonforest merged commit 8677b0a into master Apr 29, 2020
@gakonst gakonst deleted the YAS-322/Synthetix/LoggingUpdates branch March 18, 2021 15:01
snario pushed a commit that referenced this pull request Apr 14, 2021
@axchu
Audit/tob4 potential overflow 200 (#115)
3e5fe50 
* safemathwrapper

* use openzeppelin's safemath

* rm dangling lib import
bnoieh pushed a commit to bnoieh/optimism that referenced this pull request Apr 3, 2024
@welkin22
fix(op-node): pre-fetching handle L1 reOrg (ethereum-optimism#115)
a4e7213 
Co-authored-by: Welkin <[email protected]>
ClaytonNorthey92 added a commit to hemilabs/optimism that referenced this pull request Jun 27, 2024
@ClaytonNorthey92
Squashed 'heminetwork/' changes from ca22d9c73..b5b564702
3d9c98e 
b5b564702 popm/wasm: add wasm-opt target to optimise wasm binary (ethereum-optimism#146)
27a5081e3 tbc: allow seeds to be overwritten (ethereum-optimism#158)
18afbc403 Fix missing panic (ethereum-optimism#156)
05cee0afb tbc: remove height as the terminal condition for indexers (ethereum-optimism#152)
4402060d6 Use hemilabs/websocket fork of nhooyr.io/websocket (ethereum-optimism#153)
3df5001c4 Add initial CODEOWNERS file (ethereum-optimism#149)
a4685a57f popm/wasm: improve and tidy up Go code (ethereum-optimism#144)
41a0009c1 Add forking detection to TBC (ethereum-optimism#101)
bbeed8bac ignore ulimits in tbc when on localnet (ethereum-optimism#142)
4e1914cc6 Stopgap to re-fetch blocks with no children (ethereum-optimism#131)
12eefff06 e2e: fix issues detected by staticcheck (ethereum-optimism#134)
80153372f Add more documentation for TBC and related RPC protocol (ethereum-optimism#86)
723b63704 bfg: fix issues reported by staticcheck (ethereum-optimism#132)
509fb1be6 electrumx: fix unhandled error in NewJSONRPCRequest (ethereum-optimism#133)
b19af1e1f hemictl: use sort.Strings(...) instead of sort.Sort(sort.StringSlice(...)) (S1032) (ethereum-optimism#123)
cf7c570f9 popmd: remove unused 'handle' func and return err in connectBFG (ethereum-optimism#124)
fa2a4c4de ci: fix bug that makes version type always 'unstable' (ethereum-optimism#125)
ddc39655a ci: use org DOCKERHUB_TOKEN secret (ethereum-optimism#128)
6457d16f5 bfgd: drop btc_blocks_can refresh triggers for l2_keystones/pop_basis (ethereum-optimism#120)
2b3c096bd popm: simplify receivedKeystones variable in tests (ethereum-optimism#116)
6140bbf24 tbc: move RPC tests to a separate test file (ethereum-optimism#114)
c76571ff0 Add configuration option for static fees to web PoP miner (ethereum-optimism#119)
233817e65 popm: use simple conversion instead of unnecessary fmt.Sprintf (S1025) (ethereum-optimism#115)
2879f5fa7 e2e: improve name for variable with type `time.Duration` (ST1011) (ethereum-optimism#117)
4f31965e6 database,e2e: remove use of deprecated io/ioutil (SA1019) (ethereum-optimism#118)
e9e090696 tbc: do not recreate outpoint for ScriptHashByOutpoint. (ethereum-optimism#109)
52eefb136 ignore l2 keystones notifications in tests (ethereum-optimism#112)
eb607994c Sync Docker image environment variables with daemon configs (ethereum-optimism#111)
57281bc5d added a way to monitor and sanity-test localnet (ethereum-optimism#106)
ea1a1c94c bfgd: fix loops unconditionally exited after one interation (SA4004) (ethereum-optimism#108)
29f116fb4 Add pprof http server to daemons (ethereum-optimism#105)
18a315d7e Added README for generating forks in BTC regtest for TBC fork resolution testing (ethereum-optimism#100)
55b8f52cb more robust nextPort (ethereum-optimism#103)
48f8b293f tbcapi: use reverse byte order for hashes in serialised, tidy up (ethereum-optimism#104)
b7e9f5ecb restart initialblocks on-failure (ethereum-optimism#102)
f9d52d423 Update required Go version to v1.22.2 (ethereum-optimism#96)
f6808aa5b Fix op-proposer op-node dependency condition (fixes ethereum-optimism#98) (ethereum-optimism#99)
a882529e8 Kill all pending block downloads if a peer fails (ethereum-optimism#95)
eb66345e1 e2e: tidy up docker-compose file (ethereum-optimism#81)
34766f725 Track pending blocks with ttl package (ethereum-optimism#90)
6ed3eb88b Added configurable fee-per-vB to PoP Miner (ethereum-optimism#91)
509e31fbc Replace os.Kill with syscall.SIGTERM in signal.Notify calls (ethereum-optimism#87)

git-subtree-dir: heminetwork
git-subtree-split: b5b564702e8d3bedcdf0e0a52c22e383d7fd4dbe
bap2pecs pushed a commit to babylonlabs-io/optimism that referenced this pull request Jul 31, 2024
@gitferry
Integrate EOTS manager (ethereum-optimism#115)
4321d7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmeister willmeister willmeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masonforest @willmeister @karlfloersch