feat: add new failed deposit trace call frame #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartcontracts
force-pushed
the
sc/stop-call-trace
branch
2 times, most recently
from
bddd80e
to
fc67e9c
Compare
smartcontracts
commented
Mar 8, 2024
smartcontracts
force-pushed
the
sc/stop-call-trace
branch
from
fc67e9c
to
fbc3318
Compare
Natively supports the trace call where a deposit fails. Frame will appear empty with a "failed_deposit" type and the proper amount of gas used. Clients can now use and understand the result.
smartcontracts
force-pushed
the
sc/stop-call-trace
branch
from
fbc3318
to
9e50b7d
Compare
trianglesphere
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Natively supports the trace call where a deposit fails. Frame will appear empty with a "stop" type and the proper amount of gas used. We will need to document this to make it clear what's going on.
Tests
Added test cases.