tracer: fix incorrect gasUsed in deposit tx #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redhdx
approved these changes
Oct 29, 2024
redhdx
reviewed
Oct 30, 2024
| if st.msg.IsDepositTx && !rules.IsOptimismRegolith && err == nil { | ||
| if st.msg.IsSystemTx { | ||
| tracer.CaptureTxEnd(st.msg.GasLimit) | ||
| } | ||
| tracer.CaptureTxEnd(0) |
There was a problem hiding this comment.
The else branch is needed here.
|
Can you consider submitting a similar PR to the OP official? |
|
Regolith forks on opbnb networks are enabled from the start, so this fix is not necessary for opbnb. I suggest you submit the PR to the optimism repository. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fullnode v0.5.0
debug_traceBlockreports incorrect gasUsed in deposit tx, it's due to a bug introduced from upstream code pr.