Use a mailbox counter per device #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested by original reporter and it's working well for them too 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the counter was global to the
Clientinstance, meaning individual devices would get confused when the counter wrapped back round to 1 due to a different device's mailbox comms.Tested with modified
ec400demo and two EC400s. The servo now spins up with no issue.Also tested with EK1100 + EL3204 + EL6910 which is a failing setup in #131. This now works, although errors out due to the
ec400demo not being compatible with these modules, which is fine.Closes #131
Waiting for testing from the original reporter before merging.