No longer check mailbox counter #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested as working with the failing hardware by a kind user on Matrix. |
jamwaffles
force-pushed
the
stop-checking-mbox-counter
branch
from
875035a
to
f1c38f6
Compare
jamwaffles
added a commit
that referenced
this pull request
Nov 18, 2023
This reverts commit 4b7bafa.
jamwaffles
added a commit
that referenced
this pull request
Nov 20, 2023
Previously the counter was global to the `Client` instance, meaning individual devices would get confused when the counter wrapped back round to 1 due to a different device's mailbox comms. Closes #131 * Remove `Clone` and `PartialEq` derives on `Slave` * Revert "No longer check mailbox counter (#130)" The underlying cause of this issue is now fixed by #132.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec seems a little vague on what to actually do with the counter, and as far as I can read into SOEM's rather dence C it doesn't seem to check the value either. Based on this, I've removed the check in EtherCrab.
Closes #128