TridiagSolver: remove unused kernels #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
msimberg
approved these changes
Jun 14, 2023
albestro
force-pushed
the
alby/rank1-problem-dist
branch
3 times, most recently
from
f2e614c
to
49c63fe
Compare
albestro
force-pushed
the
alby/cleanup_solver_unused_kernels
branch
from
8ffa877
to
e3bad0e
Compare
|
cscs-ci run |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #906 +/- ##
==========================================
+ Coverage 91.21% 94.86% +3.65%
==========================================
Files 136 122 -14
Lines 8488 7460 -1028
Branches 1119 1018 -101
==========================================
- Hits 7742 7077 -665
+ Misses 572 229 -343
+ Partials 174 154 -20
|
rasolca
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #904 (and #860) many kernels are not used anymore.
Keeping this as separated fork of #904 in order to make a bit more easier the review of its algorithmic part.