TridiagSolver (distributed): "bulkerify" rank1 problem solution #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albestro
force-pushed
the
alby/rank1-problem-dist
branch
2 times, most recently
from
61a3208
to
0795300
Compare
rasolca
approved these changes
Jun 12, 2023
1 task
|
cscs-ci run |
msimberg
requested changes
Jun 14, 2023
albestro
force-pushed
the
alby/rank1-problem-dist
branch
2 times, most recently
from
702963b
to
f2e614c
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #904 +/- ##
==========================================
- Coverage 93.38% 91.29% -2.10%
==========================================
Files 137 137
Lines 8395 8446 +51
Branches 1089 1105 +16
==========================================
- Hits 7840 7711 -129
- Misses 368 569 +201
+ Partials 187 166 -21
|
msimberg
approved these changes
Jun 16, 2023
by working by column-tile-wise instead of column-element-wise
msimberg
reviewed
Jun 20, 2023
fixed by re-using existing column workspaces, by adapting them per new size requirements
|
cscs-ci run |
|
cscs-ci run |
|
Unused kernels will be merged directly on master after this gets in 😉 |
1 task
rasolca
approved these changes
Jul 4, 2023
|
cscs-ci run |
msimberg
approved these changes
Jul 4, 2023
|
cscs-ci run |
msimberg
approved these changes
Jul 4, 2023
msimberg
reviewed
Jul 4, 2023
Co-authored-by: Mikael Simberg <[email protected]>
|
cscs-ci run |
msimberg
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #860, this applies the same concepts to the distributed implementation.
Main changes:
TODO:
once current review is completed, merge forked TridiagSolver: remove unused kernels #906tridiag_rank1_barrier_busy_waitconfiguration option #907