Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: Add release date of etcd v3.4.35 #18884

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

ArkaSaha30
Copy link
Contributor

Set the v3.4.35 release date to today.

Part of #18845.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@ArkaSaha30 ArkaSaha30 force-pushed the update-release-3.4.35-release-date branch from 3960610 to 91e8ff6 Compare November 12, 2024 17:35
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @ArkaSaha30

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 23.07692% with 20 lines in your changes missing coverage. Please review.

Project coverage is 68.71%. Comparing base (bd88963) to head (599f6f1).
Report is 36 commits behind head on main.

Current head 599f6f1 differs from pull request most recent head 91e8ff6

Please upload reports for the commit 91e8ff6 to get more accurate results.

Files with missing lines Patch % Lines
server/storage/backend/backend.go 18.18% 9 Missing ⚠️
etcdctl/ctlv3/command/printer.go 0.00% 3 Missing ⚠️
etcdctl/ctlv3/command/check.go 0.00% 2 Missing ⚠️
server/embed/serve.go 0.00% 1 Missing and 1 partial ⚠️
etcdutl/etcdutl/snapshot_command.go 0.00% 1 Missing ⚠️
server/etcdserver/api/rafthttp/http.go 66.66% 0 Missing and 1 partial ⚠️
server/etcdserver/apply_v2.go 0.00% 0 Missing and 1 partial ⚠️
server/lease/leasehttp/http.go 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files with missing lines Coverage Δ
etcdctl/ctlv3/command/elect_command.go 0.00% <ø> (ø)
etcdctl/ctlv3/command/ep_command.go 0.00% <ø> (ø)
etcdctl/ctlv3/command/lease_command.go 0.00% <ø> (ø)
etcdctl/ctlv3/command/printer_fields.go 0.00% <ø> (ø)
etcdctl/ctlv3/command/printer_simple.go 0.00% <ø> (ø)
etcdctl/ctlv3/command/printer_table.go 0.00% <ø> (ø)
etcdctl/ctlv3/command/snapshot_command.go 0.00% <ø> (ø)
etcdctl/ctlv3/command/user_command.go 0.00% <ø> (ø)
etcdctl/ctlv3/ctl.go 0.00% <ø> (ø)
etcdutl/ctl.go 0.00% <ø> (ø)
... and 13 more

... and 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18884      +/-   ##
==========================================
- Coverage   68.78%   68.71%   -0.07%     
==========================================
  Files         420      420              
  Lines       35523    35532       +9     
==========================================
- Hits        24433    24415      -18     
- Misses       9665     9691      +26     
- Partials     1425     1426       +1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd88963...91e8ff6. Read the comment docs.

@jmhbnz
Copy link
Member

jmhbnz commented Nov 12, 2024

/retitle CHANGELOG: Add release date of etcd v3.4.35
/retest

@k8s-ci-robot k8s-ci-robot changed the title CHANGELOG: set release 3.4.35 date CHANGELOG: Add release date of etcd v3.4.35 Nov 12, 2024
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArkaSaha30, ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit 1316f3a into etcd-io:main Nov 12, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants