Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan to release etcd v3.4.35 #18845

Closed
2 tasks done
ivanvc opened this issue Nov 6, 2024 · 15 comments
Closed
2 tasks done

Plan to release etcd v3.4.35 #18845

ivanvc opened this issue Nov 6, 2024 · 15 comments
Assignees
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature

Comments

@ivanvc
Copy link
Member

ivanvc commented Nov 6, 2024

What would you like to be added?

The etcd patch release criteria has been met for our release-3.4 stable release branch so we should release v3.4.35.

The list of commits included since the previous release is: v3.4.34...release-3.4:

Work in progress CHANGELOG is: https://github.com/etcd-io/etcd/blob/main/CHANGELOG/CHANGELOG-3.4.md#v3435-tbc

List of pull requests we still need to backport from main to release-3.4 before the patch release is issued:

Release team

GitHub handle Role
@jmhbnz Release Advisor
@ivanvc Release Lead
@ArkaSaha30 Release Shadow
@henrybear327 Release Shadow

Why is this needed?

Regular patch releases are vital to ensure our users have bug-free and secure software.

@ivanvc ivanvc added type/feature priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 6, 2024
@ivanvc
Copy link
Member Author

ivanvc commented Nov 6, 2024

As discussed on Slack, it would be an excellent opportunity to do the release in person next week at KubeCon.

@ivanvc
Copy link
Member Author

ivanvc commented Nov 6, 2024

We should update to Go 1.22.9 (#18847)

@ivanvc
Copy link
Member Author

ivanvc commented Nov 7, 2024

I volunteer to be either the release lead or a shadow.

@ghouscht
Copy link
Contributor

ghouscht commented Nov 7, 2024

I volunteer to help as a shadow. However I'm not at KubeCon and the timezone difference to central europe might complicate things. If you find someone else to help, I'd be happy to renounce.

@henrybear327
Copy link
Contributor

henrybear327 commented Nov 7, 2024

I volunteer to help as a shadow, too! Same timezone as @ghouscht (Zurich)

@ArkaSaha30
Copy link
Contributor

I want to volunteer as a shadow for the release 🤚

@jmhbnz
Copy link
Member

jmhbnz commented Nov 7, 2024

Discussed during sig-etcd triage meeting. We are looking at Tuesday next week MST timezone for the release. Team has been updated above.

Team please confirm if you could make a time for around 09:00 on Tuesday Utah time?

@ivanvc
Copy link
Member Author

ivanvc commented Nov 8, 2024

9:00 am MT sounds good to me.

Edit: But I think we should release v3.5.17 first (#18846). So, it may be actually more like 10 am MT?

@ivanvc
Copy link
Member Author

ivanvc commented Nov 8, 2024

@jmhbnz, should we schedule 3.5 at 9 am and 3.4 at 10 am?

@ivanvc
Copy link
Member Author

ivanvc commented Nov 9, 2024

Can you help me do a pass at issues and PRs that may need backporting since 3.4.34 (September 11th)?

I'll also do a pass later this weekend.

@ivanvc
Copy link
Member Author

ivanvc commented Nov 10, 2024

I swept through issues/PR and added the ones that caught my eye (which, in this case, were actually just mine 😅). Please let me know if you think there are more we should consider.

@ArkaSaha30
Copy link
Contributor

We ran into https issue while committing the release and the fix for it is a backport.

@ivanvc
Copy link
Member Author

ivanvc commented Nov 12, 2024

The release script incorrectly tagged the GitHub release as "latest". The CLI documentation is not explicit. After researching, I found that the HTML mentions to set --latest=false (ref: https://cli.github.com/manual/gh_release_create). I'll open a pull request myself, as I want to verify that it works on my fork.

Edit: It was due to an old github-cli version. However, updating to the latest didn't have an effect.

@ivanvc
Copy link
Member Author

ivanvc commented Nov 12, 2024

I'll track the gh release issues/findings at #18604.

@ivanvc
Copy link
Member Author

ivanvc commented Nov 13, 2024

Thanks, team (@henrybear327, @ArkaSaha30, @jmhbnz), with all follow-up tasks closed and the release in place. I'll go ahead and close this issue 🎉

@ivanvc ivanvc closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature
Development

No branches or pull requests

5 participants