[3.5] Backport livez/readyz #17039
Merged
[3.5] Backport livez/readyz #17039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chao Chen <[email protected]>
Add two separate probes, one for liveness and one for readiness. The liveness probe would check that the local individual node is up and running, or else restart the node, while the readiness probe would check that the cluster is ready to serve traffic. This would make etcd health-check fully Kubernetes API complient. Signed-off-by: Siyuan Zhang <[email protected]>
Signed-off-by: Siyuan Zhang <[email protected]>
|
Should we backport e2e tests too? |
|
In order to backport the e2e test, it would require backporting a lot of the e2e test framework, because existing Failpoint is in a this agent handler which is very hard to reuse. Is that worth the effort? @serathius |
|
Yes, it requires some effort, but we should not add features without proper e2e test coverage. Please let me know if you need help with backport. |
siyuanfoundation
force-pushed
the
release-3.5-step2
branch
2 times, most recently
from
3404053 to
c74cf77
Compare
|
Note, I didn't mean that we should backport the e2e framework changes, just backport the e2e test. |
siyuanfoundation
force-pushed
the
release-3.5-step2
branch
2 times, most recently
from
1a7d50b to
118b5ae
Compare
|
Looking at the e2e framework backports I think it would be easier to move it to separate PR so we ensure it's properly reviewed. |
siyuanfoundation
force-pushed
the
release-3.5-step2
branch
from
118b5ae to
bd74dca
Compare
|
Will backport e2e tests as followup PRs. |
serathius
approved these changes
Dec 6, 2023
|
cc @ahrtr |
|
Also which PR are you backporting? Please provide a link to the original PR. |
ahrtr
reviewed
Dec 6, 2023
Signed-off-by: Siyuan Zhang <[email protected]>
siyuanfoundation
force-pushed
the
release-3.5-step2
branch
from
bd74dca to
ebb7e79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
Part of #16007
Follow up of #17000
Original PRs:
#16697
#16651
#16797
#16984