Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcdserver: add linearizable_read check to readyz. #16984

Merged
merged 1 commit into from
Nov 21, 2023
Merged

etcdserver: add linearizable_read check to readyz. #16984

merged 1 commit into from
Nov 21, 2023

Conversation

siyuanfoundation
Copy link
Contributor

@siyuanfoundation siyuanfoundation commented Nov 20, 2023 •
edited
Loading

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Follow up of #16792:

Because ReadIndex check requires non-trivial changes, it would be difficult to backport.
To unblock livez/readyz, a fallback to the old linearizable_read check would meet the MVP, the new livez/readyz checks would be no worse than the old /heath checks, and minimize the risk for backporting.

@siyuanfoundation
Copy link
Contributor Author

cc @chaochn47 @serathius @ahrtr

@serathius
Copy link
Member

cc @ahrtr

fuweid
fuweid approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one question

server/etcdserver/api/etcdhttp/health_test.go Outdated Show resolved Hide resolved
ahrtr
ahrtr approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ahrtr ahrtr merged commit fd0882b into etcd-io:main Nov 21, 2023
34 checks passed
@siyuanfoundation siyuanfoundation deleted the lin-read branch November 21, 2023 23:17
@siyuanfoundation siyuanfoundation mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

@fuweid fuweid fuweid approved these changes

@serathius serathius serathius approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siyuanfoundation @serathius @fuweid @ahrtr