-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
memberID equals zero in corruption alarm #14272
Conversation
0f0358a
to
7645ac7
Compare
6e3b284
to
a798812
Compare
Codecov Report
@@ Coverage Diff @@
## main #14272 +/- ##
==========================================
- Coverage 75.40% 75.24% -0.16%
==========================================
Files 456 456
Lines 36919 36946 +27
==========================================
- Hits 27838 27800 -38
- Misses 7345 7394 +49
- Partials 1736 1752 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
@@ -16,6 +16,7 @@ Previous change logs can be found at [CHANGELOG-3.4](https://github.com/etcd-io/ | |||
- Fix [lessor may continue to schedule checkpoint after stepping down leader role](https://github.com/etcd-io/etcd/pull/14087). | |||
- Fix [Restrict the max size of each WAL entry to the remaining size of the WAL file](https://github.com/etcd-io/etcd/pull/14127). | |||
- Fix [Protect rangePermCache with a RW lock correctly](https://github.com/etcd-io/etcd/pull/14227) | |||
- Fix [memberID equals zero in corruption alarm](https://github.com/etcd-io/etcd/pull/14272) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you will update this once the PR is backported to 3.5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
ping @ahrtr |
Signed-off-by: Marek Siarkowicz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ahrtr It might be worth considering backporting this to v3.4 release as currently corruption checks will not report which member is corrupted making the restore process require manually finding corrupted member. |
Sure, let me take care of it for 3.4. |
cc @ahrtr