-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove memberID from data corruption alarm #14849
Labels
Comments
The easiest solution might be intentionally set the memberID as 0, otherwise we need to update the alarm structure. WDYT? @serathius |
Sounds Good |
Related to #14272 |
This was referenced Nov 25, 2022
Note, can develop changes first on |
Only 3.4 and 3.5 need this change. main will follow #14828 |
Resolved. |
ahrtr
added a commit
to ahrtr/etcd
that referenced
this issue
Nov 25, 2022
…orrupted member If quorum doesn't exist, we don't know which members data are corrupted. In such situation, we intentionally set the memberID as 0, it means it affects the whole cluster. It's align with what we did for 3.4 and 3.5 in etcd-io#14849 Signed-off-by: Benjamin Wang <[email protected]>
ahrtr
added a commit
to ahrtr/etcd
that referenced
this issue
Nov 26, 2022
…orrupted member If quorum doesn't exist, we don't know which members data are corrupted. In such situation, we intentionally set the memberID as 0, it means it affects the whole cluster. It's align with what we did for 3.4 and 3.5 in etcd-io#14849 Signed-off-by: Benjamin Wang <[email protected]>
ahrtr
added a commit
to ahrtr/etcd
that referenced
this issue
Nov 26, 2022
…orrupted member If quorum doesn't exist, we don't know which members data are corrupted. In such situation, we intentionally set the memberID as 0, it means it affects the whole cluster. It's align with what we did for 3.4 and 3.5 in etcd-io#14849 Signed-off-by: Benjamin Wang <[email protected]>
serathius
pushed a commit
to serathius/etcd
that referenced
this issue
Dec 2, 2022
…orrupted member If quorum doesn't exist, we don't know which members data are corrupted. In such situation, we intentionally set the memberID as 0, it means it affects the whole cluster. It's align with what we did for 3.4 and 3.5 in etcd-io#14849 Signed-off-by: Benjamin Wang <[email protected]> Signed-off-by: Marek Siarkowicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
Only leader performs the corruption check, and it always assumes that it's one of the followers' data corrupted. It isn't correct, it's also possible that the leader data corrupted.
Please refer the discussion in #14828
What did you expect to happen?
Remove memberID from data corruption alarm or set it as 0.
How can we reproduce it (as minimally and precisely as possible)?
Trigger a data corruption.
Anything else we need to know?
We only need to fix this for 3.5 and 3.4.
Etcd version (please run commands below)
Etcd configuration (command line flags or environment variables)
paste your configuration here
Etcd debug information (please run commands blow, feel free to obfuscate the IP address or FQDN in the output)
Relevant log output
No response
The text was updated successfully, but these errors were encountered: