Update to grpc-1.47 (and fix the connection-string format) #14125
Conversation
ptabor
force-pushed
the
20220615-update-grpc2
branch
from
8149ed0 to
6214e2d
Compare
| @@ -9,7 +9,7 @@ require ( | |||
| github.com/grpc-ecosystem/grpc-gateway v1.16.0 | |||
| github.com/stretchr/testify v1.7.0 | |||
| google.golang.org/genproto v0.0.0-20211118181313-81c1377c94b1 | |||
| google.golang.org/grpc v1.41.0 | |||
| google.golang.org/grpc v1.47.0 | |||
There was a problem hiding this comment.
The title mentions 1.48, but actually 1.47
There was a problem hiding this comment.
:) I guess it's a typo in the PR title as the latest stable release is 1.47. lgmt.
There was a problem hiding this comment.
Good catch. Reworded.
ptabor
force-pushed
the
20220615-update-grpc2
branch
from
624c7bf to
24886f7
Compare
ptabor
changed the title
|
@ptabor Overall the PR looks good to me. But I don't understand why do you add one more directory |
Signed-off-by: Piotr Tabor <[email protected]>
Signed-off-by: Piotr Tabor <[email protected]>
ptabor
force-pushed
the
20220615-update-grpc2
branch
from
24886f7 to
cbf54a0
Compare
Removed it. It was produces by intelij. I've just added to it to |
…he connection-string format) Signed-off-by: Chao Chen <[email protected]>
…he connection-string format) Signed-off-by: Chao Chen <[email protected]>
…he connection-string format) Signed-off-by: Chao Chen <[email protected]>
…he connection-string format) Signed-off-by: Chao Chen <[email protected]>
Minimal change required to upgrade to grpc-1.47.
#14112. Connecting to
unix:localhost:portinstead of never officially supportedunix://localhost:port(https://grpc.github.io/grpc/cpp/md_doc_naming.html)