-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump OpenTelemetry dependencies to v1.7.0 #14104
Conversation
This is the probably 4th attempt to bump the OpenTelemetry. Note that all previous attempts were failed. It could be due to the behavior change on the new gRPC version. It would be helpful if you get it resolved. |
@ahrtr I noticed unfortunately 😭 but I wanted to give it a try |
I think one of the problems is
|
I was looking into this. The real problem is grpc upgrade and it seems that new grpc version is more strict about format of the 'connection targets'. In particular our tests depend a lot on Etcd also assumes ability to parse out the port from the url... so there is a lot of legacy to scribe here. |
This is very important think to note. Thanks @ptabor for pointing this out I think we should working towards grpc url standards to avoid similar issues in future. |
Signed-off-by: Luca Comellini <[email protected]>
Signed-off-by: Luca Comellini <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #14104 +/- ##
==========================================
- Coverage 75.43% 75.24% -0.20%
==========================================
Files 454 454
Lines 36938 36916 -22
==========================================
- Hits 27864 27777 -87
- Misses 7344 7411 +67
+ Partials 1730 1728 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Closing as it's done in #14125 |
@ptabor it looks like only grpc was updated, not otel? 🤔 |
Bumps OpenTelemetry dependencies to v1.7.0