Stop using golang tip version in CI #13338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @lilic |
ptabor
approved these changes
Sep 10, 2021
lilic
approved these changes
Sep 10, 2021
|
ok, I think that Semaphore fails as it tries to test in docker. Docker test require us to build a dedicated image that is versioned with golang version. I think I will skip updating golang to speed up this fix (need to cherry pick it to release-3.5) |
serathius
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to disable using tip golang version ("^1.16" means at least 1.16), and set one version in both CI and build. This is meant to avoid issues like #13334 where CI can break when new Go version is released. Having reproducible test is very important for fast resolution of bugs and reduction of flakes. This PR sets 1.16 version instead of upgrading to 1.16 as it should be also cherry-picked to v3.5 which is affected with the same problem.
Historically we also tested on Golang tip, but as a test that can fail. Having additional signal from "tip" in CI is a separate problem, that we can take a look after.
@ptabor