Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix IsOptsWithFromKey #13334

Merged
merged 1 commit into from
Sep 10, 2021
Merged

fix IsOptsWithFromKey #13334

merged 1 commit into from
Sep 10, 2021

Conversation

LeoYang90
Copy link

fix #13332

@LeoYang90 LeoYang90 mentioned this pull request Sep 9, 2021
Closed
serathius
serathius reviewed Sep 9, 2021
View reviewed changes
Copy link
Member

@serathius serathius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this. Aside of one nit this looks good.

I'm still struggling to understand how this issue got on main branch, and why I'm unable to reproduce it locally.
Do you have any idea?

client/v3/op.go Show resolved Hide resolved
@serathius
Copy link
Member

Also can you squash commits? second commit in the PR just removes trailing whitespace. It would be better if this is put in single commit.

serathius
serathius approved these changes Sep 9, 2021
View reviewed changes
Copy link
Member

@serathius serathius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be inclined to merge it as it is to unblock other PRs.

ptabor
ptabor reviewed Sep 9, 2021
View reviewed changes
client/v3/op.go Outdated Show resolved Hide resolved
ptabor
ptabor approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@ptabor ptabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing.

@LeoYang90 LeoYang90 force-pushed the fix_IsOptsWithFromKey branch from 860ee92 to fc042f5 Compare September 9, 2021 15:24
fix IsOptsWithFromKey
ad69fe0 
fix IsOptsWithFromKey

fix IsOptsWithFromKey

fix IsOptsWithFromKey

fix IsOptsWithFromKey

fix IsOptsWithFromKey
@LeoYang90 LeoYang90 force-pushed the fix_IsOptsWithFromKey branch from 973998a to ad69fe0 Compare September 9, 2021 16:45
@tsaarni
Copy link
Contributor

tsaarni commented Sep 9, 2021

I'm still struggling to understand how this issue got on main branch, and why I'm unable to reproduce it locally.
Do you have any idea?

Go version got upgraded in github action #13311 (comment)

@tsaarni tsaarni mentioned this pull request Sep 9, 2021
Closed
@serathius
Copy link
Member

@tsaarni Nice find, but also terrifying. I think we should fix it to make test reproducible.

@ptabor
Copy link
Contributor

ptabor commented Sep 10, 2021

All green. Great. Merging.

@ptabor ptabor merged commit 58fb625 into etcd-io:main Sep 10, 2021
@serathius serathius mentioned this pull request Sep 10, 2021
Merged
@vivekpatani
Copy link
Contributor

Hi folks, any plans to port this back to release-3.5? @serathius @ptabor @LeoYang90
If it's not already done, I can help port it back. Thanks.

@ptabor
Copy link
Contributor

ptabor commented Feb 23, 2022

Thank you, Vivek. Porting seems right to me. Will approve the PR.

vivekpatani pushed a commit to vivekpatani/etcd that referenced this pull request Feb 24, 2022
*: fix IsOptsWithFromKey
7cec92a 
porting back from 3.5 from main
PR etcd-io#13334
@vivekpatani vivekpatani mentioned this pull request Feb 24, 2022
Merged
vivekpatani pushed a commit to vivekpatani/etcd that referenced this pull request Jul 19, 2022
clientv3: fix isOptsWithFromKey/isOptsWithPrefix
b6112f8 
- Addressing: etcd-io#13332
- Backporting: etcd-io#13334
vivekpatani added a commit to vivekpatani/etcd that referenced this pull request Jul 19, 2022
@vivekpatani
clientv3: fix isOptsWithFromKey/isOptsWithPrefix
0d9d159 
- Addressing: etcd-io#13332
- Backporting: etcd-io#13334
@vivekpatani vivekpatani mentioned this pull request Jul 19, 2022
Merged
vivekpatani added a commit to vivekpatani/etcd that referenced this pull request Jul 20, 2022
@vivekpatani
clientv3: fix isOptsWithFromKey/isOptsWithPrefix
4fef7fc 
- Addressing: etcd-io#13332
- Backporting: etcd-io#13334

Signed-off-by: vivekpatani <[email protected]>
tjungblu pushed a commit to tjungblu/etcd that referenced this pull request Sep 7, 2022
@tjungblu
*: fix IsOptsWithFromKey
6052ef5 
porting back from 3.5 from main
PR etcd-io#13334
tjungblu pushed a commit to tjungblu/etcd that referenced this pull request Sep 8, 2022
@vivekpatani @tjungblu
clientv3: fix isOptsWithFromKey/isOptsWithPrefix
972792e 
- Addressing: etcd-io#13332
- Backporting: etcd-io#13334

Signed-off-by: vivekpatani <[email protected]>
@ahrtr ahrtr mentioned this pull request Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptabor ptabor ptabor approved these changes

@serathius serathius serathius approved these changes

Assignees
No one assigned
Labels
backport/v3.5
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Function isOpFuncCalled can not work fine
5 participants
@LeoYang90 @serathius @tsaarni @ptabor @vivekpatani