Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ./script/fix.sh & test.sh OSX/BSD compatible #12602

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

ptabor
Copy link
Contributor

@ptabor ptabor commented Jan 7, 2021

  • build & test scripts deprecated. Call *.sh variants.
    This will avoid delete the symlinks and get rid of
    subtle dependency on 'sed --follow-symlinks' on OsX/BSD sed.
  • Fix parameters to mktemp
  • Replace 'mapfile' with a for-loop to stay bash 3.2 compatible

@ptabor ptabor force-pushed the 20210107-scripts-on-osx branch from 4b8bdee to 1f4661c Compare January 12, 2021 15:12
- build & test scripts deprecated. Call *.sh variants.
  This will avoid delete the symlinks and get rid of
  subtle dependency on 'sed --follow-symlinks' on OsX/BSD sed.

- Fix parameters to mktemp
@ptabor ptabor force-pushed the 20210107-scripts-on-osx branch from 1f4661c to 84b5b87 Compare January 12, 2021 15:30
Copy link
Contributor

@jingyih jingyih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jingyih jingyih merged commit c95d943 into etcd-io:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants