Update grpc-go to v1.33.0 #12597

scDisorder · 2021-01-04T22:33:50Z

if im done it right and I can be more accessible than #12398

fix register.go imports

client/v3/balancer/balancer.go

client/v3/go.mod

ptabor · 2021-01-05T11:44:53Z

Thank you for working on this. I tried to test it locally, and spotted that:

The code still depends on the naming package:
% ./scripts/fix.sh

...
stderr: go: finding module for package google.golang.org/grpc/naming
stderr: go.etcd.io/etcd/tests/v3/integration/clientv3 tested by
stderr: go.etcd.io/etcd/tests/v3/integration/clientv3.test imports
stderr: google.golang.org/grpc/naming: module google.golang.org/grpc@latest found (v1.34.0), but does not contain package google.golang.org/grpc/naming
FAIL: (code:1):
  % (cd tests && 'go' 'mod' 'tidy')

This is blocking integration tests run, that allows to take a look whether the solution works e2e (so probably hides problems with protobuf 1.4.4):

% PASSES="fmt unit integration" ./test

ptabor · 2021-01-05T11:58:33Z

After (temporarily) removing the tests above I got:

% PASSES="fmt unit integration" ./test

FAIL: inconsistent versions for depencency: github.com/golang/protobuf
  - github.com/golang/[email protected] from: go.etcd.io/etcd/api/v3
  - github.com/golang/[email protected] from: go.etcd.io/etcd/raft/v3
  - github.com/golang/[email protected] from: go.etcd.io/etcd/server/v3
  - github.com/golang/[email protected] from: go.etcd.io/etcd/tests/v3
FAIL: inconsistent versions for depencency: google.golang.org/genproto
  - google.golang.org/[email protected] from: go.etcd.io/etcd/api/v3
  - google.golang.org/[email protected] from: go.etcd.io/etcd/server/v3
FAIL: inconsistent versions for depencency: google.golang.org/grpc
  - google.golang.org/[email protected] from: go.etcd.io/etcd/api/v3
  - google.golang.org/[email protected] from: go.etcd.io/etcd/pkg/v3
  - google.golang.org/[email protected] from: go.etcd.io/etcd/client/v3
  - google.golang.org/[email protected] from: go.etcd.io/etcd/etcdctl/v3
  - google.golang.org/[email protected] from: go.etcd.io/etcd/server/v3
  - google.golang.org/[email protected] from: go.etcd.io/etcd/tests/v3
  - google.golang.org/[email protected] from: go.etcd.io/etcd/v3
FAIL: inconsistent dependencies
FAIL: 'dep' failed at Tue 05 Jan 2021 12:50:24 PM CET

Please let me know when the tests pass or you need some help.

scDisorder · 2021-01-05T13:38:54Z

gimme a moment

scDisorder · 2021-01-05T14:10:54Z

so i have met an issue on ./scripts/fix.sh:

generating bill-of-materials.json
% (cd tools/mod && 'gobin' '-p' '-m' '--mod=readonly' 'github.com/coreos/license-bill-of-materials')
% '/Users/disorder/go/src/go.etcd.io/etcd-io/etcd/tools/mod/.gobincache/github.com/coreos/license-bill-of-materials/@v/v0.0.0-20190913234955-13baff47494e/license-bill-of-materials' '--override-file' './bill-of-materials.override.json' 'go.etcd.io/etcd/api/v3/...' 'go.etcd.io/etcd/pkg/v3/...' 'go.etcd.io/etcd/raft/v3/...' 'go.etcd.io/etcd/client/v2/...' 'go.etcd.io/etcd/client/v3/...' 'go.etcd.io/etcd/server/v3/...' 'go.etcd.io/etcd/etcdctl/v3/...' 'go.etcd.io/etcd/tests/v3/...' 'go.etcd.io/etcd/v3/...'
bom refreshed
Fixing whitespaces in the bash scripts
find ./ -name '*.sh' -print0 | xargs -0 sed --follow-symlinks -i 's|\t|  |g'
sed: illegal option -- -
usage: sed script [-Ealnru] [-i extension] [file ...]
	sed [-Ealnu] [-i extension] [-e script] ... [-f script_file] ... [file ...]

which also ruins make test i think

% (cd tests && 'env' 'go' 'test' '-short' '-timeout=3m' '-cpu=4' '--race' './...')
ok  	go.etcd.io/etcd/tests/v3/e2e	0.624s
ok  	go.etcd.io/etcd/tests/v3/functional/agent	0.149s
?   	go.etcd.io/etcd/tests/v3/functional/cmd/etcd-agent	[no test files]
?   	go.etcd.io/etcd/tests/v3/functional/cmd/etcd-proxy	[no test files]
?   	go.etcd.io/etcd/tests/v3/functional/cmd/etcd-runner	[no test files]
?   	go.etcd.io/etcd/tests/v3/functional/cmd/etcd-tester	[no test files]
ok  	go.etcd.io/etcd/tests/v3/functional/rpcpb	0.166s
?   	go.etcd.io/etcd/tests/v3/functional/runner	[no test files]
ok  	go.etcd.io/etcd/tests/v3/functional/tester	0.178s
--- FAIL: TestSnapshotAndRestartMember (8.63s)
    member_test.go:103: #118: create on unix://127.0.0.1:2100278932 error: dial unix 127.0.0.1:2100278932: socket: too many open files
{"level":"info","ts":"2021-01-05T17:08:12.140+0300","caller":"embed/etcd.go:113","msg":"configuring peer listeners","listen-peer-urls":["http://localhost:2380"]}
{"level":"info","ts":"2021-01-05T17:08:12.143+0300","caller":"embed/etcd.go:121","msg":"configuring client listeners","listen-client-urls":["http://localhost:2379"]}
{"level":"info","ts":"2021-01-05T17:08:12.143+0300","caller":"embed/etcd.go:268","msg":"starting an etcd server","etcd-version":"3.5.0-pre","git-sha":"Not provided (use ./build instead of go build)","go-version":"go1.15.6","go-os":"darwin","go-arch":"amd64","max-cpu-set":4,"max-cpu-available":16,"member-initialized":false,"name":"default","data-dir":"/var/folders/77/tvjc55cj31l7v8fpz2qk6rcm0000gn/T/etcd-805961113","wal-dir":"","wal-dir-dedicated":"","member-dir":"/var/folders/77/tvjc55cj31l7v8fpz2qk6rcm0000gn/T/etcd-805961113/member","force-new-cluster":false,"heartbeat-interval":"100ms","election-timeout":"1s","initial-election-tick-advance":true,"snapshot-count":100000,"snapshot-catchup-entries":5000,"initial-advertise-peer-urls":["http://localhost:2380"],"listen-peer-urls":["http://localhost:2380"],"advertise-client-urls":["http://localhost:2379"],"listen-client-urls":["http://localhost:2379"],"listen-metrics-urls":[],"cors":["*"],"host-whitelist":["*"],"initial-cluster":"default=http://localhost:2380","initial-cluster-state":"new","initial-cluster-token":"etcd-cluster","quota-size-bytes":2147483648,"pre-vote":false,"initial-corrupt-check":false,"corrupt-check-time-interval":"0s","auto-compaction-mode":"","auto-compaction-retention":"0s","auto-compaction-interval":"0s","discovery-url":"","discovery-proxy":"","downgrade-check-interval":"5s"}
{"level":"info","ts":"2021-01-05T17:08:12.168+0300","caller":"etcdserver/backend.go:78","msg":"opened backend db","path":"/var/folders/77/tvjc55cj31l7v8fpz2qk6rcm0000gn/T/etcd-805961113/member/snap/db","took":"24.195392ms"}
{"level":"info","ts":"2021-01-05T17:08:12.238+0300","caller":"etcdserver/raft.go:447","msg":"starting local member","local-member-id":"8e9e05c52164694d","cluster-id":"cdf818194e3a8c32"}
{"level":"info","ts":"2021-01-05T17:08:12.240+0300","caller":"raft/raft.go:1528","msg":"8e9e05c52164694d switched to configuration voters=()"}
{"level":"info","ts":"2021-01-05T17:08:12.240+0300","caller":"raft/raft.go:701","msg":"8e9e05c52164694d became follower at term 0"}
{"level":"info","ts":"2021-01-05T17:08:12.240+0300","caller":"raft/raft.go:383","msg":"newRaft 8e9e05c52164694d [peers: [], term: 0, commit: 0, applied: 0, lastindex: 0, lastterm: 0]"}
{"level":"info","ts":"2021-01-05T17:08:12.240+0300","caller":"raft/raft.go:701","msg":"8e9e05c52164694d became follower at term 1"}
make: *** [test] Error 1

as well PASSES="fmt unit integration" ./test ruins with:

'mod_tidy' started at Tue Jan  5 17:56:29 MSK 2021
mktemp: illegal option -- -
usage: mktemp [-d] [-q] [-t prefix] [-u] template ...
       mktemp [-d] [-q] [-u] -t prefix 
% (cd api && 'cp' './go.mod' './go.sum' '')
stderr: cp: ./go.mod and ./go.mod are identical (not copied).
stderr: cp: ./go.sum and ./go.sum are identical (not copied).
FAIL: (code:1):
  % (cd api && 'cp' './go.mod' './go.sum' '')
FAIL: 'mod_tidy' failed at Tue Jan  5 17:56:29 MSK 2021

for now.

looking for an issue now, but ill be glad for ideas

is there a need for me to set up some special environments before running tests?
i'm running it on macos big sur

ptabor · 2021-01-05T20:20:30Z

Oh... I don't have BSD / Osx testing environment, so don't see these problems.

OsX sed does not support --follow-symlinks settings.
This doc points on some workarounds:
https://www.cyberciti.biz/faq/howto-prevent-sed-i-from-destroying-symlinks-on-linux-unix/

mktemp seems also like a difference between GNU and BSD. I will try to borrow a Mac and fix these.

scDisorder · 2021-01-06T09:54:47Z

am i getting it right that i just need to go through all the .sh files and remove double spaces?
probably i can write something like if uname == Darwin then call loop alike something

edited:
ah, got ya, i'll be ready then, but would try something

ptabor · 2021-01-06T10:10:47Z

Replace tabs with double spaced. But the check would still trigger... So you can temporarily disable it.

…

On Wed, Jan 6, 2021, 9:55 AM Dmitriy ***@***.***> wrote: am i getting it right that i just need to go through all the .sh files and remove double spaces? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#12597 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACXZAYZMDNIMOIODBQBSA33SYQXPTANCNFSM4VTWRSEQ> .

scDisorder · 2021-01-06T10:31:45Z

i get it work fine by brew install gnu-sed and adding this for a moment:

if [ $(uname) == "Darwin" ]
  then
    find ./ -name '*.sh' -print0 | xargs -0 gsed --follow-symlinks -i 's|\t|  |g'
  else
    find ./ -name '*.sh' -print0 | xargs -0 sed --follow-symlinks -i 's|\t|  |g'
  fi

gsed can be linked and used as sed btw

also fixed mktemp command in test.sh like that:
tmpModDir=$(mktemp -d --suffix "etcd-mod" 2>/dev/null || mktemp -d -t 'tmpModDir')
looks like --suffix flag cannot be used on mac too

scDisorder · 2021-01-06T11:17:07Z

i didnt commited but i used

SED=sed
if [ $(uname) == "Darwin" ]
  then
    SED=gsed
fi

and replaced all sed usage with $SED, but it seems as a crutch, so everything is fine except mktemp which conflicts with --suffix flag and requires -t flag, but can be fixed as i mentioned above
now i have met panic on test

raft2021/01/06 13:59:27 INFO: 1 became leader at term 1
raft2021/01/06 13:59:27 INFO: raft.node: 1 elected leader 1 at term 1
panic: field raftpb.Message.type has invalid type: got raftpb.MessageType, want pointer

goroutine 10 [running]:
google.golang.org/protobuf/internal/impl.fieldInfoForScalar(0x1bdf160, 0xc00020aa80, 0x19c7540, 0x4, 0x0, 0x0, 0x1bdf280, 0x19e78a0, 0x19c7546, 0x45, ...)
	/Users/disorder/go/pkg/mod/google.golang.org/[email protected]/internal/impl/message_reflect_field.go:228 +0xa85
google.golang.org/protobuf/internal/impl.(*MessageInfo).makeKnownFieldsFunc(0xc000160a00, 0x180, 0xffffffffffffffff, 0x168, 0xffffffffffffffff, 0xc000210b70, 0xc000210ba0, 0xc000210bd0, 0xc000210c00)
	/Users/disorder/go/pkg/mod/google.golang.org/[email protected]/internal/impl/message_reflect.go:67 +0xcc5
google.golang.org/protobuf/internal/impl.(*MessageInfo).makeReflectFuncs(0xc000160a00, 0x1bdf280, 0x1a657a0, 0x180, 0xffffffffffffffff, 0x168, 0xffffffffffffffff, 0xc000210b70, 0xc000210ba0, 0xc000210bd0, ...)
	/Users/disorder/go/pkg/mod/google.golang.org/[email protected]/internal/impl/message_reflect.go:36 +0xca
google.golang.org/protobuf/internal/impl.(*MessageInfo).initOnce(0xc000160a00)
	/Users/disorder/go/pkg/mod/google.golang.org/[email protected]/internal/impl/message.go:90 +0x235
google.golang.org/protobuf/internal/impl.(*MessageInfo).init(0xc000160a00)
	/Users/disorder/go/pkg/mod/google.golang.org/[email protected]/internal/impl/message.go:72 +0x65
google.golang.org/protobuf/internal/impl.(*messageReflectWrapper).Has(0xc0001dd200, 0x1bdf160, 0xc00020aa80, 0xc00020aa80)
	/Users/disorder/go/pkg/mod/google.golang.org/[email protected]/internal/impl/message_reflect_gen.go:185 +0x5a
github.com/golang/protobuf/proto.(*textWriter).writeMessage(0xc0002108d0, 0x1bdd000, 0xc0001dd200, 0x0, 0x0)
	/Users/disorder/go/pkg/mod/github.com/golang/[email protected]/proto/text_encode.go:278 +0xb62
github.com/golang/protobuf/proto.(*TextMarshaler).marshal(0x1f7179e, 0x1bd2320, 0xc00020dba0, 0xc000308cf0, 0x2c, 0x0, 0x0, 0x2c)
	/Users/disorder/go/pkg/mod/github.com/golang/[email protected]/proto/text_encode.go:86 +0x2d6
github.com/golang/protobuf/proto.(*TextMarshaler).Text(...)
	/Users/disorder/go/pkg/mod/github.com/golang/[email protected]/proto/text_encode.go:44
github.com/golang/protobuf/proto.CompactTextString(...)
	/Users/disorder/go/pkg/mod/github.com/golang/[email protected]/proto/text_encode.go:106
go.etcd.io/etcd/raft/v3/raftpb.(*Message).String(...)
	/Users/disorder/go/src/go.etcd.io/etcd-io/etcd/raft/raftpb/raft.pb.go:409
go.etcd.io/etcd/raft/v3.TestNodeProposeWaitDropped.func1(0xc000290000, 0x2, 0x0, 0x1, 0x0, 0x0, 0x0, 0xc0002a6730, 0x1, 0x1, ...)
	/Users/disorder/go/src/go.etcd.io/etcd-io/etcd/raft/node_test.go:462 +0x43c
go.etcd.io/etcd/raft/v3.(*raft).Step(0xc000290000, 0x2, 0x0, 0x1, 0x0, 0x0, 0x0, 0xc0002a6730, 0x1, 0x1, ...)
	/Users/disorder/go/src/go.etcd.io/etcd-io/etcd/raft/raft.go:990 +0xfd8
go.etcd.io/etcd/raft/v3.(*node).run(0xc0003ea5a0)
	/Users/disorder/go/src/go.etcd.io/etcd-io/etcd/raft/node.go:346 +0x1158
created by go.etcd.io/etcd/raft/v3.TestNodeProposeWaitDropped
	/Users/disorder/go/src/go.etcd.io/etcd-io/etcd/raft/node_test.go:474 +0x6de
FAIL	go.etcd.io/etcd/raft/v3	0.104s
ok  	go.etcd.io/etcd/raft/v3/confchange	(cached)
ok  	go.etcd.io/etcd/raft/v3/quorum	(cached)
ok  	go.etcd.io/etcd/raft/v3/raftpb	(cached)
ok  	go.etcd.io/etcd/raft/v3/rafttest	(cached)
ok  	go.etcd.io/etcd/raft/v3/tracker	(cached)
FAIL
FAIL: (code:1):
  % (cd raft && 'env' 'go' 'test' '-short' '-timeout=3m' '-cpu=4' '--race' './...')
FAIL: 'unit' failed at Wed Jan  6 13:59:27 MSK 2021

would investigate now

ptabor · 2021-01-06T22:27:54Z

This exact scary things happens if you update protobuf libraries too much. Please export you current go.mod changes.

Are you sure all the dependencies are protobuf-1.3.x ?

There might be something transitivily pooled up... so maybe sticking to e.g. grpc-1.30 in first step might help...

scDisorder · 2021-01-07T08:10:53Z

so it only was run fine when im on 1.4.2 so i did commit it
ill try it again with 1.3.5

scDisorder · 2021-01-07T11:12:01Z

so as I can see there is no way to use grpc 1.33+ with protobuf version less than 1.4.1
just take a look at this: https://github.com/grpc/grpc-go/blob/v1.33.x/go.mod
and the 1.32 version had protobuf 1.3.3 dependency
i ll try to downgrade grpc-go then... kinda sad

scDisorder · 2021-01-07T11:20:48Z

the only thing I cant get is why script fix installing 1.4.2 version for server and tests package so hard
as well removing go.sum file and go mod tidy results the same

ptabor · 2021-01-07T11:30:54Z

Grepping go mod graph helps with understanding the transitive dependency that causes the version bump.

go mod tidy - bumps the dependency to minimal version of the transitive dependencies.

ptabor · 2021-01-07T11:35:41Z

FYI: Proposed Darwin compatible fixes to the scripts: #12602

scDisorder · 2021-01-07T12:01:01Z

i am not sure, but probably this ruins everything for me:

% (cd server && 'go' 'mod' 'tidy')
stderr: go: finding module for package google.golang.org/grpc/examples/helloworld/helloworld
stderr: go: found google.golang.org/grpc/examples/helloworld/helloworld in google.golang.org/grpc/examples v0.0.0-20210105215357-f4a20d2f414f

there is mod graph when i manually go get github.com/golang/[email protected] in server and tests directories

cloud.google.com/[email protected] github.com/golang/[email protected]
cloud.google.com/[email protected] github.com/golang/[email protected]
cloud.google.com/go/[email protected] github.com/golang/[email protected]
cloud.google.com/go/[email protected] github.com/golang/[email protected]
cloud.google.com/[email protected] github.com/golang/[email protected]
cloud.google.com/go/[email protected] github.com/golang/[email protected]
cloud.google.com/[email protected] github.com/golang/[email protected]
cloud.google.com/go/[email protected] github.com/golang/[email protected]
cloud.google.com/go/[email protected] github.com/golang/[email protected]
cloud.google.com/[email protected] github.com/golang/[email protected]
github.com/spf13/[email protected] github.com/gogo/[email protected]
github.com/prometheus/[email protected] github.com/golang/[email protected]
github.com/prometheus/[email protected] github.com/matttproud/[email protected]
go.etcd.io/etcd/tests/[email protected] github.com/gogo/[email protected]
go.etcd.io/etcd/tests/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
github.com/gogo/[email protected] github.com/kisielk/[email protected]
github.com/gogo/[email protected] github.com/kisielk/[email protected]
github.com/gogo/[email protected] github.com/kisielk/[email protected]
github.com/prometheus/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
github.com/grpc-ecosystem/[email protected] github.com/golang/[email protected]
github.com/prometheus/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
github.com/prometheus/[email protected] github.com/gogo/[email protected]
github.com/prometheus/[email protected] github.com/golang/[email protected]
github.com/prometheus/[email protected] github.com/matttproud/[email protected]
[email protected] github.com/golang/[email protected]
github.com/grpc-ecosystem/[email protected] github.com/golang/[email protected]
github.com/prometheus/[email protected] github.com/golang/[email protected]
go.etcd.io/etcd/api/[email protected] github.com/gogo/[email protected]
go.etcd.io/etcd/api/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
github.com/prometheus/[email protected] github.com/golang/[email protected]
github.com/prometheus/[email protected] github.com/gogo/[email protected]
github.com/prometheus/[email protected] github.com/golang/[email protected]
github.com/prometheus/[email protected] github.com/matttproud/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
github.com/prometheus/[email protected] github.com/golang/[email protected]
github.com/prometheus/[email protected] github.com/matttproud/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
github.com/envoyproxy/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
go.etcd.io/etcd/etcdctl/[email protected] github.com/gogo/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
github.com/cncf/udpa/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
go.etcd.io/etcd/raft/[email protected] github.com/gogo/[email protected]
go.etcd.io/etcd/raft/[email protected] github.com/golang/[email protected]
github.com/prometheus/[email protected] github.com/golang/[email protected]
github.com/cockroachdb/[email protected] github.com/gogo/[email protected]
github.com/prometheus/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
github.com/prometheus/[email protected] github.com/gogo/[email protected]
github.com/prometheus/[email protected] github.com/golang/[email protected]
github.com/prometheus/[email protected] github.com/matttproud/[email protected]
github.com/grpc-ecosystem/[email protected] github.com/golang/[email protected]
github.com/grpc-ecosystem/[email protected] github.com/gogo/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
github.com/envoyproxy/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
go.etcd.io/etcd/server/[email protected] github.com/golang/[email protected]
go.etcd.io/etcd/server/[email protected] github.com/gogo/[email protected]
github.com/envoyproxy/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]

then goes go mod tidy and go mod graph | grep [email protected]

github.com/golang/[email protected] github.com/google/[email protected]
github.com/golang/[email protected] google.golang.org/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
github.com/golang/[email protected] github.com/google/[email protected]
github.com/golang/[email protected] google.golang.org/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
go.etcd.io/etcd/tests/[email protected] github.com/golang/[email protected]
github.com/golang/[email protected] github.com/google/[email protected]
github.com/golang/[email protected] google.golang.org/[email protected]
github.com/golang/[email protected] github.com/google/[email protected]
github.com/golang/[email protected] google.golang.org/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
google.golang.org/grpc/[email protected] github.com/golang/[email protected]
github.com/golang/[email protected] github.com/google/[email protected]
github.com/golang/[email protected] google.golang.org/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
github.com/golang/[email protected] github.com/google/[email protected]
github.com/golang/[email protected] google.golang.org/[email protected]
go.etcd.io/etcd/server/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
github.com/golang/[email protected] github.com/google/[email protected]
github.com/golang/[email protected] google.golang.org/[email protected]

ptabor · 2021-01-07T12:19:14Z

Hate to say that, but 'replace' directive for protobuf or/and go-cmp in tests&server module might be the only option to decouple both problems.

scDisorder · 2021-01-07T12:58:25Z

something like

replace github.com/golang/protobuf => github.com/golang/protobuf v1.3.5
replace github.com/google/go-cmp => github.com/google/go-cmp v0.4.0

does not helps if i get it right, so i just would reset it to head and would upgrade grpc without crazy version jumpings

im only hope that master test wouldnt fail now and i have a point to begin %)

scDisorder · 2021-01-07T13:18:23Z

even grpc 1.30 gives me the same result
i can suspect my environments only for now, but i cannot adapt it only for etcd. probably would close the pr, or idk
i have a lot of generated pb files keeping on the last stable and do really need that update for my app, so i had to try

scDisorder · 2021-01-07T20:14:47Z

yep, i have found a solution with alpha version of client

ptabor · 2021-01-08T17:48:14Z

I kept poking around this, and found a few interesting things:

google.golang.org/grpc/examples/helloworld/helloworld dependency is due to cmux.

% go mod why google.golang.org/grpc/examples/helloworld/helloworld

# google.golang.org/grpc/examples/helloworld/helloworld
go.etcd.io/etcd/server/v3/embed
github.com/soheilhy/cmux
github.com/soheilhy/cmux.test
google.golang.org/grpc/examples/helloworld/helloworld

We have dependency on cmux currently, so I don't understand why our grpc bump is causing that to be added to go.mod (and not earlier).
There is PR in tmux to separate their examplar code from the main product and define go.mod:
Adopt go modules soheilhy/cmux#81
Last release was 2 years ago, so we might need to e.g. fork that project.
cmd/go: provide straightforward way to see non-test dependencies golang/go#26955 is the gophers discussion about adding transitively test-dependencies into go.mod.
My opinion: They assume idealistic state of the world, and do not provide tools to deal with a real problems in the ecosystem.
I resumed discussions about solving problem of 'gogo' that is blocking adoption of grpc-1.30+ due to ... transitively testing... dependencies. Public issue: 🐘 Need a replacement for deprecated/unmaintained gogo-protobuf dependency kubernetes/kubernetes#96564 (comment)

@scDisorder : I think it is still worth to merge a CL that solves the picker & naming problem, even if we stay for now on grpc-1.29.1 (both versions of packages are available in 1.29.1). Would you mind continuation of work on this,
or you prefer someone to resume / fork ?

@skyao for lessons learned in context of: #12398

scDisorder · 2021-01-09T08:50:52Z

@ptabor yep, I can try to do this again

scDisorder · 2021-01-09T09:14:38Z

i also see that gogo proto has latest version update for almost 2 years ago

so am i getting it right that i should have 2 separate PRs:

move grpc/naming code to internal naming package as i have done before
and picker issue, but im not sure when to start: i mean should i wait for cmux merge or something

scDisorder · 2021-01-09T09:48:13Z

@ptabor take a look on #12608 when you able to

skyao · 2021-01-11T11:11:10Z

@scDisorder we can work together for this grpc version upgrade issue . In fact this problem has been blocked for a long long time as you can see from my PR(the first one).

scDisorder added 5 commits January 4, 2021 16:24

update grpc-go to 1.34.0

6fd436d

update go.mod and go.sum

26426e6

fix register.go imports

update go-grpc version

070cf58

update api/version

bcfcf87

revert api/version

e9752ff

scDisorder changed the title ~~Update grpc go~~ Update grpc-go to v1.34.0 Jan 4, 2021

haorenfsa reviewed Jan 5, 2021

View reviewed changes

client/v3/balancer/balancer.go Outdated Show resolved Hide resolved

remove endless recursion from balancer Close method

fa81de4

ptabor reviewed Jan 5, 2021

View reviewed changes

client/v3/go.mod Outdated Show resolved Hide resolved

decrease grpc version to 1.33 and protobuf to 1.3.3

0160c33

scDisorder added 2 commits January 5, 2021 17:19

fix go mods

f728aa3

use protobuf 1.3.5

cecfe84

scDisorder changed the title ~~Update grpc-go to v1.34.0~~ Update grpc-go to v1.33.0 Jan 5, 2021

scDisorder added 2 commits January 5, 2021 18:29

fix tests go.mod file

3978108

remove grpcproxy package duplicated operation type

21ee47c

scDisorder marked this pull request as draft January 5, 2021 15:45

rmfitzpatrick mentioned this pull request Jan 5, 2021

Add MonitorCustomConfig support to Smart Agent Receiver signalfx/splunk-otel-collector#54

Merged

fix dependencies issues

88b9dec

use protobuf 1.3.5

7001dc1

use grpc-go 1.32.0

24da350

scDisorder closed this Jan 7, 2021

ptabor mentioned this pull request Jan 7, 2021

etcd not compatible with grpc v1.30.0 #12124

Closed

scDisorder mentioned this pull request Jan 9, 2021

do not use grpc/naming package #12608

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update grpc-go to v1.33.0 #12597

Update grpc-go to v1.33.0 #12597

scDisorder commented Jan 4, 2021

ptabor commented Jan 5, 2021

ptabor commented Jan 5, 2021

scDisorder commented Jan 5, 2021

scDisorder commented Jan 5, 2021 •

edited

Loading

ptabor commented Jan 5, 2021

scDisorder commented Jan 6, 2021 •

edited

Loading

ptabor commented Jan 6, 2021 via email

scDisorder commented Jan 6, 2021 •

edited

Loading

scDisorder commented Jan 6, 2021

ptabor commented Jan 6, 2021

scDisorder commented Jan 7, 2021 •

edited

Loading

scDisorder commented Jan 7, 2021

scDisorder commented Jan 7, 2021 •

edited

Loading

ptabor commented Jan 7, 2021

ptabor commented Jan 7, 2021

scDisorder commented Jan 7, 2021

ptabor commented Jan 7, 2021

scDisorder commented Jan 7, 2021 •

edited

Loading

scDisorder commented Jan 7, 2021 •

edited

Loading

scDisorder commented Jan 7, 2021

ptabor commented Jan 8, 2021

scDisorder commented Jan 9, 2021

scDisorder commented Jan 9, 2021 •

edited

Loading

scDisorder commented Jan 9, 2021

skyao commented Jan 11, 2021

Update grpc-go to v1.33.0 #12597

Update grpc-go to v1.33.0 #12597

Conversation

scDisorder commented Jan 4, 2021

ptabor commented Jan 5, 2021

ptabor commented Jan 5, 2021

scDisorder commented Jan 5, 2021

scDisorder commented Jan 5, 2021 • edited Loading

ptabor commented Jan 5, 2021

scDisorder commented Jan 6, 2021 • edited Loading

ptabor commented Jan 6, 2021 via email

scDisorder commented Jan 6, 2021 • edited Loading

scDisorder commented Jan 6, 2021

ptabor commented Jan 6, 2021

scDisorder commented Jan 7, 2021 • edited Loading

scDisorder commented Jan 7, 2021

scDisorder commented Jan 7, 2021 • edited Loading

ptabor commented Jan 7, 2021

ptabor commented Jan 7, 2021

scDisorder commented Jan 7, 2021

ptabor commented Jan 7, 2021

scDisorder commented Jan 7, 2021 • edited Loading

scDisorder commented Jan 7, 2021 • edited Loading

scDisorder commented Jan 7, 2021

ptabor commented Jan 8, 2021

scDisorder commented Jan 9, 2021

scDisorder commented Jan 9, 2021 • edited Loading

scDisorder commented Jan 9, 2021

skyao commented Jan 11, 2021

scDisorder commented Jan 5, 2021 •

edited

Loading

scDisorder commented Jan 6, 2021 •

edited

Loading

scDisorder commented Jan 6, 2021 •

edited

Loading

scDisorder commented Jan 7, 2021 •

edited

Loading

scDisorder commented Jan 7, 2021 •

edited

Loading

scDisorder commented Jan 7, 2021 •

edited

Loading

scDisorder commented Jan 7, 2021 •

edited

Loading

scDisorder commented Jan 9, 2021 •

edited

Loading