Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asana | Fix events stream #1320

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Conversation

Z33DD
Copy link
Contributor

@Z33DD Z33DD commented Mar 5, 2024

Description:

According to airbytehq/airbyte#31114 and airbytehq/airbyte#31114, those streams will throw errors if the account doesn't pay for an Asana's paid plan.
The problem with the events' stream is the different pagination style that demands the first request to return a 'Precondition Failed' failed error (412).

About the Events stream, it is broken because of pagination, so it is not related to the paid account issue. I tested this flow with both paid and free accounts, the error is the sync token. I also added a condition in the next_page_token method to stop reading if the API returns has_more as false.

Pagination for HTTP API connectors

Asana API Reference:


This change is Reviewable

@Z33DD Z33DD added the bug Something isn't working label Mar 5, 2024
@Z33DD Z33DD self-assigned this Mar 5, 2024
@Z33DD
Copy link
Contributor Author

Z33DD commented Mar 5, 2024

The PR checks are failing for some other connectors. As my code doesn’t affect them, I don’t know how to proceed.
In the case of the Asana source, it's a problem in the way the workflow is configured.

Copy link
Member

@jgraettinger jgraettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgraettinger jgraettinger merged commit 6c21028 into main Mar 7, 2024
50 of 59 checks passed
@jgraettinger jgraettinger deleted the FIX/source-asana/events-stream branch March 7, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants