-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Source Asana: Add Portfolios stream #31114
✨ Source Asana: Add Portfolios stream #31114
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
@topefolorunso According to the Asana docs, this endpoint requires an owner field to passed into the request to successfully fetch records, currently the read command for this stream is not working, can you look into fixing this? |
Not sure about this @sajarin. Only the workspace parameter is required. If the owner parameter is not specified, all portfolios under the workspace will be returned. This is according to the asana docs. |
@topefolorunso I tested the request myself using the api explorer and the api errors out with "owner" value is missing. This is also causing the integration tests to fail in the linked PR. If you don't believe me, you can try simulating a request yourself to the API using credentials. Either way, the current implementation of the stream is broken. |
Any update here @topefolorunso? |
apologies @sajarin , got caught up with other issues. I'm trying to see the best way we can get the owner value for the stream - stream to partition from or from config |
@topefolorunso this should most likely be fetched from a stream slice, let me know if you're able to continue working on this |
@sajarin Yes I can continue working on this. But one issue, what stream will I slice from? I was thinking the |
What
Add Asana Portfolios stream resolves #16804
How
Recommended reading order
x.java
y.python
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user?
For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.
If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Actions
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.