Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Asana: Add Portfolios stream #31114

Merged
merged 10 commits into from
Nov 3, 2023

Conversation

topefolorunso
Copy link
Collaborator

What

Add Asana Portfolios stream resolves #16804

How

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 5:22pm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@sajarin sajarin changed the title Source Asana: Add Portfolios stream ✨ Source Asana: Add Portfolios stream Oct 20, 2023
@sajarin
Copy link
Contributor

sajarin commented Oct 23, 2023

@topefolorunso According to the Asana docs, this endpoint requires an owner field to passed into the request to successfully fetch records, currently the read command for this stream is not working, can you look into fixing this?

@topefolorunso
Copy link
Collaborator Author

@topefolorunso According to the Asana docs, this endpoint requires an owner field to passed into the request to successfully fetch records, currently the read command for this stream is not working, can you look into fixing this?

Not sure about this @sajarin. Only the workspace parameter is required. If the owner parameter is not specified, all portfolios under the workspace will be returned. This is according to the asana docs.

image

@sajarin
Copy link
Contributor

sajarin commented Oct 23, 2023

@topefolorunso I tested the request myself using the api explorer and the api errors out with "owner" value is missing. This is also causing the integration tests to fail in the linked PR. If you don't believe me, you can try simulating a request yourself to the API using credentials.

Either way, the current implementation of the stream is broken.

@sajarin
Copy link
Contributor

sajarin commented Oct 25, 2023

Any update here @topefolorunso?

@topefolorunso
Copy link
Collaborator Author

Any update here @topefolorunso?

apologies @sajarin , got caught up with other issues. I'm trying to see the best way we can get the owner value for the stream - stream to partition from or from config

@sajarin
Copy link
Contributor

sajarin commented Oct 27, 2023

@topefolorunso this should most likely be fetched from a stream slice, let me know if you're able to continue working on this

@topefolorunso
Copy link
Collaborator Author

@topefolorunso this should most likely be fetched from a stream slice, let me know if you're able to continue working on this

@sajarin Yes I can continue working on this. But one issue, what stream will I slice from? I was thinking the Users stream and the gid property of the stream, but I don't see anywhere in the API documentation where it states that this property maps with the owner parameter we need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Source Asana: new stream Portfolios
4 participants