Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsuite: decrease timestep for better accuracy in langevin test. #3137

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

KaiSzuttor
Copy link
Member

Fixes #3135

@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #3137 into python will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #3137    +/-   ##
=======================================
+ Coverage      84%     84%   +<1%     
=======================================
  Files         526     526            
  Lines       26112   26112            
=======================================
+ Hits        22157   22158     +1     
+ Misses       3955    3954     -1
Impacted Files Coverage Δ
src/core/particle_data.cpp 96% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c7bc5a...c3eb2f6. Read the comment docs.

@jngrad
Copy link
Member

jngrad commented Sep 6, 2019

bors r+

bors bot added a commit that referenced this pull request Sep 6, 2019
3131: Features without tests require EXPERIMENTAL_FEATURES r=jngrad a=RudolfWeeber

As announced in #2071, this marks all features experimental that do not have test coverage.

These features can still be used but EXPERIMENTAL_FEATURES needs to be defined in myconfig.hpp

Please consider contributing tests for the features listed below.
Features that do not have test coverage for an extended period are candidates for removal.

OIF-related:
* Affinity, membrane collision

IBM-related:
* IBM_volCons

Interactions:
* HarmonicDumbbell 
* DipolarDirectSumWithReplicaCPU

Shapes:
* Stomatocyte 

Gay-Berne is no longer marked experimental, since tests have been added recently.


3136: Fix issues with Gitlab CI dag r=jngrad a=RudolfWeeber

Fixes partly #3134

3137: testsuite: decrease timestep for better accuracy in langevin test. r=jngrad a=KaiSzuttor

Fixes #3135

Co-authored-by: Rudolf Weeber <[email protected]>
Co-authored-by: Kai Szuttor <[email protected]>
@bors
Copy link
Contributor

bors bot commented Sep 6, 2019

Build succeeded

@bors bors bot merged commit c3eb2f6 into espressomd:python Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Langevin Test Fails on the institute machines
2 participants