Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAG in GitLab-CI shortcomings #3134

Closed
jngrad opened this issue Sep 5, 2019 · 3 comments
Closed

DAG in GitLab-CI shortcomings #3134

jngrad opened this issue Sep 5, 2019 · 3 comments
Labels
DevOps

Comments

@jngrad
Copy link
Member

jngrad commented Sep 5, 2019

The new CI dependency graph introduced in #3109 (later modified in #3133) doesn't always work.

For example when stage 1 fails, stage 3 still runs instead of going directly to stage 4:
https://gitlab.icp.uni-stuttgart.de/espressomd/espresso/pipelines/9012

When some jobs in stage 2 fail, stage 3 can't start and we never reach stage 4:
https://gitlab.icp.uni-stuttgart.de/espressomd/espresso/pipelines/9023
@jngrad jngrad added the DevOps label Sep 5, 2019
@RudolfWeeber RudolfWeeber mentioned this issue Sep 6, 2019
Merged
@jngrad
Copy link
Member Author

jngrad commented Sep 6, 2019

Offline discussion with @RudolfWeeber: we might have to re-create the scenario described above in PRs and tweak the DAG until it's fixed.

bors bot added a commit that referenced this issue Sep 6, 2019
@bors @RudolfWeeber @KaiSzuttor
Merge #3131 #3136 #3137
d225cbd 
3131: Features without tests require EXPERIMENTAL_FEATURES r=jngrad a=RudolfWeeber

As announced in #2071, this marks all features experimental that do not have test coverage.

These features can still be used but EXPERIMENTAL_FEATURES needs to be defined in myconfig.hpp

Please consider contributing tests for the features listed below.
Features that do not have test coverage for an extended period are candidates for removal.

OIF-related:
* Affinity, membrane collision

IBM-related:
* IBM_volCons

Interactions:
* HarmonicDumbbell 
* DipolarDirectSumWithReplicaCPU

Shapes:
* Stomatocyte 

Gay-Berne is no longer marked experimental, since tests have been added recently.


3136: Fix issues with Gitlab CI dag r=jngrad a=RudolfWeeber

Fixes partly #3134

3137: testsuite: decrease timestep for better accuracy in langevin test. r=jngrad a=KaiSzuttor

Fixes #3135

Co-authored-by: Rudolf Weeber <[email protected]>
Co-authored-by: Kai Szuttor <[email protected]>
@jngrad
Copy link
Member Author

jngrad commented Sep 10, 2019

It looks like check_cuda_maxset_no_gpu is sometimes rebuilding the core and Python interface instead of recycling the artifacts, which increases the runtime from 5 min to 20 min:
https://gitlab.icp.uni-stuttgart.de/espressomd/espresso/-/jobs/159169

@jngrad jngrad mentioned this issue Feb 20, 2020
Closed
@jngrad
Copy link
Member Author

jngrad commented Jun 1, 2020

This is no longer an issue on the python branch. Closing.

@jngrad jngrad closed this as completed Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DevOps
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jngrad