Core: Use slightly smaller value when adjusting max skin in tune_skin #3132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## python #3132 +/- ##
========================================
+ Coverage 83% 84% +<1%
========================================
Files 530 480 -50
Lines 26141 21420 -4721
========================================
- Hits 21949 18022 -3927
+ Misses 4192 3398 -794
Continue to review full report at Codecov.
|
jngrad
approved these changes
Sep 5, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 5, 2019
3125: Document Correlator.result() r=jngrad a=pkreissl Fixes #2997 Description of changes: - Document `result` method of `Correlator` class. Documentation done by @christophlohrmann. 3132: Core: Use slightly smaller value when adjusting max skin in tune_skin r=jngrad a=RudolfWeeber @jngrad, this removes one potential issue with the p3m benchmark. 3133: CI: The cuda no_gpu test doesn't need a gpu runner r=jngrad a=RudolfWeeber Fixes # Description of changes: - PR Checklist ------------ - [ ] Tests? - [ ] Interface - [ ] Core - [ ] Docs? Co-authored-by: Christoph Lohrmann <[email protected]> Co-authored-by: Patrick Kreissl <[email protected]> Co-authored-by: Rudolf Weeber <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jngrad, this removes one potential issue with the p3m benchmark.