Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Correlator.result() #3125

Merged
merged 2 commits into from
Sep 5, 2019
Merged

Conversation

pkreissl
Copy link
Contributor

@pkreissl pkreissl commented Sep 5, 2019

Fixes #2997

Description of changes:

@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #3125 into python will decrease coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3125   +/-   ##
======================================
- Coverage      83%     83%   -1%     
======================================
  Files         530     530           
  Lines       26141   26125   -16     
======================================
- Hits        21949   21933   -16     
  Misses       4192    4192
Impacted Files Coverage Δ
src/core/accumulators/Correlator.hpp 90% <ø> (ø) ⬆️
src/core/thermostat.cpp 97% <0%> (-2%) ⬇️
src/core/particle_data.cpp 95% <0%> (-1%) ⬇️
src/core/constraints/ShapeBasedConstraint.cpp 87% <0%> (-1%) ⬇️
src/core/forces_inline.hpp 81% <0%> (-1%) ⬇️
src/core/thermostat.hpp 97% <0%> (-1%) ⬇️
src/core/pressure.cpp 90% <0%> (-1%) ⬇️
...re/bonded_interactions/bonded_interaction_data.hpp 100% <0%> (ø) ⬆️
src/core/constraints/HomogeneousMagneticField.cpp 100% <0%> (ø) ⬆️
src/core/forces.cpp 100% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72da9ac...c3eb186. Read the comment docs.

@jngrad
Copy link
Member

jngrad commented Sep 5, 2019

bors r+

bors bot added a commit that referenced this pull request Sep 5, 2019
3125: Document Correlator.result() r=jngrad a=pkreissl

Fixes #2997 

Description of changes:
 - Document `result` method of `Correlator` class. Documentation done by @christophlohrmann.


3132: Core: Use slightly smaller value when adjusting max skin in tune_skin r=jngrad a=RudolfWeeber

@jngrad, this removes one potential issue with the p3m benchmark.


3133: CI: The cuda no_gpu test doesn't need a gpu runner r=jngrad a=RudolfWeeber

Fixes #

Description of changes:
 - 


PR Checklist
------------
 - [ ] Tests?
   - [ ] Interface
   - [ ] Core 
 - [ ] Docs?


Co-authored-by: Christoph Lohrmann <[email protected]>
Co-authored-by: Patrick Kreissl <[email protected]>
Co-authored-by: Rudolf Weeber <[email protected]>
@bors
Copy link
Contributor

bors bot commented Sep 5, 2019

Build succeeded

@bors bors bot merged commit c3eb186 into espressomd:python Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Py: Document correlator.result()
3 participants