Add event stack size option to esp_hidh_config_t and increase default event stack size in esp_hid_host example (IDFGH-4568) #6385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
changed the title
|
Thanks for your contribution. |
|
Thanks for your contribution, and sorry for late reply, we have put the changes into our internal review queue, and the PR will be updated once the changes are available on GitHub. Thanks. |
espressif-bot
added
Status: Done
espressif-bot
pushed a commit
that referenced
this pull request
May 17, 2021
espressif-bot
pushed a commit
that referenced
this pull request
May 17, 2021
|
Thank you for the PR @LMBernardo, the fixes have been cherry-picked as d1c8c26 and 5266d81. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default stack size value of 2048 given to the "esp_bt_hidh_events" and "esp_ble_hidh_events" tasks make them prone to stack overflows on rapid events. The new value of 4096 seems to mitigate this issue for human-speed mouse and keyboard inputs, however may be insufficient for other cases, e.g., HID scanners, emulated HID devices, etc. Adding the event stack size as an option to the existing config struct allows for flexibility.
Resolves #6380